Update documentation of logging.Filter.filter() by soulmerge · Pull Request #22692 · python/cpython · GitHub
Skip to content

Update documentation of logging.Filter.filter() - #22692

Merged
vsajip merged 1 commit into
python:masterfrom
soulmerge:master
Oct 16, 2020
Merged

Update documentation of logging.Filter.filter()#22692
vsajip merged 1 commit into
python:masterfrom
soulmerge:master

Conversation

@soulmerge

@soulmerge soulmerge commented Oct 14, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

bpo-42011: Update documentation of logging.Filter.filter()

@soulmerge
soulmerge requested a review from vsajip as a code owner October 14, 2020 08:02
@the-knights-who-say-ni

the-knights-who-say-ni commented Oct 14, 2020

Copy link
Copy Markdown

@JulienPalard

JulienPalard commented Oct 14, 2020

Copy link
Copy Markdown
Member

Thanks for this PR!

LGTM, don't forget to sign the CLA.

Seluj78
Seluj78 approved these changes Oct 14, 2020
View reviewed changes

@Seluj78 Seluj78 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your documentation improvement !

@Pyrex421

Pyrex421 commented Oct 15, 2020

Copy link
Copy Markdown

bpo-42011: Update documentation of logging.Filter.filter()

vsajip
vsajip requested changes Oct 15, 2020
View reviewed changes

@vsajip vsajip left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is fine, but the CLA needs to be signed before this PR can be merged. Currently, it's still showing as not signed.

@bedevere-bot

bedevere-bot commented Oct 15, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@soulmerge

soulmerge commented Oct 16, 2020

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Oct 16, 2020

Copy link
Copy Markdown

Thanks for making the requested changes!

@vsajip: please review the changes made to this pull request.

@bedevere-bot
bedevere-bot requested a review from vsajip October 16, 2020 07:59
@vsajip
vsajip merged commit e9959c7 into python:master Oct 16, 2020
@miss-islington

miss-islington commented Oct 16, 2020

Copy link
Copy Markdown
Contributor

Thanks @soulmerge for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Oct 16, 2020

Copy link
Copy Markdown
Contributor

Thanks @soulmerge for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Oct 16, 2020

Copy link
Copy Markdown

GH-22724 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 16, 2020
@soulmerge @miss-islington
bpo-42011: Update documentation of logging.Filter.filter() (pythonGH-…
ad67b7e 
…22692)

(cherry picked from commit e9959c7)

Co-authored-by: Necdet Can Atesman <can@atesman.at>
@bedevere-bot

bedevere-bot commented Oct 16, 2020

Copy link
Copy Markdown

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 16, 2020
@soulmerge @miss-islington
bpo-42011: Update documentation of logging.Filter.filter() (pythonGH-…
0472c8c 
…22692)

(cherry picked from commit e9959c7)

Co-authored-by: Necdet Can Atesman <can@atesman.at>
vsajip pushed a commit that referenced this pull request Oct 16, 2020
@miss-islington
bpo-42011: Update documentation of logging.Filter.filter() (GH-22692) (…
8f7eab7 
…GH-22724)

(cherry picked from commit e9959c7)
vsajip pushed a commit that referenced this pull request Oct 16, 2020
@miss-islington
bpo-42011: Update documentation of logging.Filter.filter() (GH-22692) (…
dff9161 
…GH-22725)

(cherry picked from commit e9959c7)
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@soulmerge @xzy3-cdc
bpo-42011: Update documentation of logging.Filter.filter() (pythonGH-…
3be2475 
…22692)
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@soulmerge @adorilson
bpo-42011: Update documentation of logging.Filter.filter() (pythonGH-…
7cf963d 
…22692)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vsajip vsajip Awaiting requested review from vsajip
1 more reviewer
@Seluj78 Seluj78 Seluj78 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@soulmerge @the-knights-who-say-ni @JulienPalard @Pyrex421 @bedevere-bot @miss-islington @vsajip @Seluj78