bpo-41900: C14N 2.0 serialisation failed for unprefixed attributes when a default namespace was defined. by scoder · Pull Request #22474 · python/cpython · GitHub
Skip to content

bpo-41900: C14N 2.0 serialisation failed for unprefixed attributes when a default namespace was defined. #22474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scoder merged 1 commit into from
Oct 3, 2020
Merged

bpo-41900: C14N 2.0 serialisation failed for unprefixed attributes when a default namespace was defined. #22474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Lib/test/test_xml_etree.py
View file
Open in desktop
5 changes: 5 additions & 0 deletions Lib/xml/etree/ElementTree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1876,6 +1876,11 @@ def _qname(self, qname, uri=None):
self._declared_ns_stack[-1].append((uri, prefix))
return f'{prefix}:{tag}' if prefix else tag, tag, uri

if not uri:
# As soon as a default namespace is defined,
# anything that has no namespace (and thus, no prefix) goes there.
return tag, tag, uri

raise ValueError(f'Namespace "{uri}" is not declared in scope')

def data(self, data):
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2020-10-01-10-50-12.bpo-41900.Cho7oh.rst
View file
Open in desktop