{{ message }}
bpo-41700: Skip test if the locale is not supported - #22081
Merged
Merged
Conversation
corona10
added
skip issue
skip news
and removed
awaiting core review
tests
vstinner
reviewed
Sep 3, 2020
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
Your PR doesn't fix the issue, see https://bugs.python.org/issue41700#msg376320 to reproduce the issue.
vstinner
approved these changes
Sep 4, 2020
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM. I tested manually that the PR fix https://bugs.python.org/issue41700.
It should be backport to 3.9, and maybe also to 3.8, no?
Member
Author
Contributor
|
Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
|
GH-22085 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 4, 2020
(cherry picked from commit 54a66ad) Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 4, 2020
(cherry picked from commit 54a66ad) Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
|
GH-22086 is a backport of this pull request to the 3.8 branch. |
corona10
added a commit
that referenced
this pull request
Sep 4, 2020
corona10
added a commit
that referenced
this pull request
Sep 4, 2020
shihai1991
added a commit
to shihai1991/cpython
that referenced
this pull request
Sep 5, 2020
…lots1 * origin/master: (63 commits) bpo-41627: Distinguish 32 and 64-bit user site packages on Windows (pythonGH-22098) bpo-38585: Remove references to defusedexpat (pythonGH-22095) bpo-41721: Add xlc options (pythonGH-22096) bpo-40486: Specify what happens if directory content change diring iteration (pythonGH-22025) bpo-41638: Improve ProgrammingError message for absent parameter. (pythonGH-21999) bpo-41713: _signal doesn't use multi-phase init (pythonGH-22087) bpo-41700: Skip test if the locale is not supported (pythonGH-22081) [doc] Update documentation on logging optimization. (pythonGH-22075) Fix 'gather' rules in the python parser generator (pythonGH-22021) bpo-41697: Correctly handle KeywordOrStarred when parsing arguments in the parser (pythonGH-22077) [doc] Fix a typo in the graphlib docs (python#22030) bpo-1635741: Port _signal module to multi-phase init (PEP 489) (pythonGH-22049) bpo-39883: Use BSD0 license for code in docs (pythonGH-17635) bpo-39010: Improve test shutdown (python#22066) bpo-41696: Fix handling of debug mode in asyncio.run (python#22069) bpo-41690: Use a loop to collect args in the parser instead of recursion (pythonGH-22053) closes bpo-41689: Preserve text signature from tp_doc in C heap type creation. (pythonGH-22058) Fix invalid escape sequences in the peg_highlight Sphinx extension (pythonGH-22047) bpo-41675: Modernize siginterrupt calls (pythonGH-22028) bpo-41685: Don't pin setuptools version anymore in Doc/Makefile (pythonGH-22062) ...
xzy3
pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue41700