bpo-41361: Converting collections.deque methods to Argument Clinic by corona10 · Pull Request #21584 · python/cpython · GitHub
Skip to content

bpo-41361: Converting collections.deque methods to Argument Clinic - #21584

Closed
corona10 wants to merge 1 commit into
python:masterfrom
corona10:bpo-41361
Closed

bpo-41361: Converting collections.deque methods to Argument Clinic#21584
corona10 wants to merge 1 commit into
python:masterfrom
corona10:bpo-41361

Conversation

@corona10

@corona10 corona10 commented Jul 21, 2020

Copy link
Copy Markdown
Member

@rhettinger

Copy link
Copy Markdown
Contributor

@rhettinger

Copy link
Copy Markdown
Contributor

I've thought about this more and think we should leave the code as-is. All of these changes interfere with my ability to read and maintain the code. Without a compelling benefit, we should just skip it. We already applied vectorcall in the place where it would help. If we really thought it necessary, we could use text signatures, but most of these methods already have very simple signatures.

@rhettinger rhettinger closed this Jul 22, 2020
@rhettinger

Copy link
Copy Markdown
Contributor

Thank you for your efforts and your understanding :-)

@corona10

Copy link
Copy Markdown
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants