Doc: Add output to example code in programming FAQ#21346
Conversation
|
I create new account in b.p.o, and singed CLA just now. |
|
I have added skip-issue and skip-news labels since minor changes don't need issue and news entry. |
|
@tirkarthi Thanks. Does it mean this PR could be merged after CLA pass/effective? |
|
It would still require an approval from a core developer to get merged. I added the labels so that the PR is green with all checks passing. |
merwok
left a comment
merwok
left a comment
There was a problem hiding this comment.
Thanks for working on this improvement!
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Co-authored-by: Éric Araujo <merwok@netwok.org>
Co-authored-by: Éric Araujo <merwok@netwok.org>
Co-authored-by: Éric Araujo <merwok@netwok.org>
Co-authored-by: Éric Araujo <merwok@netwok.org>
|
It's odd, there is a new commit in my branch zhongjiajie@5eec277 but not including in this PR, I don't know what going on. |
zhongjiajie
force-pushed
the
doc-faq-programming
branch
from
f71e07c to
5eec277
Compare
merwok
changed the title
merwok
left a comment
merwok
left a comment
There was a problem hiding this comment.
Looks good! I’d just like a second review.
|
@tirkarthi Could you please take a look at this patch? we need one more approval here |
|
So could we merge it to master? |
|
I’m just not clear about backport rules given that 3.9 is in beta |
|
Documentation changes can be backported to any maintained version. Feature freeze does not affect this. |
|
Thanks @zhongjiajie for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
Add output hint to document, part faq/programming, section [How do I write a function with output parameters (call by reference)?](https://docs.python.org/3/faq/programming.htmlGH-how-do-i-write-a-function-with-output-parameters-call-by-reference). This patch make the output hint just like prefix code block. (cherry picked from commit 67acf74) Co-authored-by: Jiajie Zhong <zhongjiajie955@hotmail.com>
|
GH-21790 is a backport of this pull request to the 3.9 branch. |
|
GH-21791 is a backport of this pull request to the 3.8 branch. |
Add output hint to document, part faq/programming, section [How do I write a function with output parameters (call by reference)?](https://docs.python.org/3/faq/programming.htmlGH-how-do-i-write-a-function-with-output-parameters-call-by-reference). This patch make the output hint just like prefix code block. (cherry picked from commit 67acf74) Co-authored-by: Jiajie Zhong <zhongjiajie955@hotmail.com>
Add output hint to document, part faq/programming, section [How do I write a function with output parameters (call by reference)?](https://docs.python.org/3/faq/programming.htmlGH-how-do-i-write-a-function-with-output-parameters-call-by-reference). This patch make the output hint just like prefix code block. (cherry picked from commit 67acf74) Co-authored-by: Jiajie Zhong <zhongjiajie955@hotmail.com>
…H-21791) Add output hint to document, part faq/programming, section [How do I write a function with output parameters (call by reference)?](https://docs.python.org/3/faq/programming.htmlGH-how-do-i-write-a-function-with-output-parameters-call-by-reference). This patch make the output hint just like prefix code block. (cherry picked from commit 67acf74) Co-authored-by: Jiajie Zhong <zhongjiajie955@hotmail.com> Automerge-Triggered-By: @merwok
Add output hint to document, part faq/programming, section [How do I write a function with output parameters (call by reference)?](https://docs.python.org/3/faq/programming.html#how-do-i-write-a-function-with-output-parameters-call-by-reference). This patch make the output hint just like prefix code block.
Add output hint to document, part faq/programming, section [How do I write a function with output parameters (call by reference)?](https://docs.python.org/3/faq/programming.html#how-do-i-write-a-function-with-output-parameters-call-by-reference). This patch make the output hint just like prefix code block.
7 participants
Add output hint to document, part faq/programming, section How do I write a function with output parameters (call by reference)?.
This patch make the output hint just like prefix code block.
Automerge-Triggered-By: @merwok