bpo-28180: assume UTF-8 for Mac OS X PEP 538 tests by ncoghlan · Pull Request #2130 · python/cpython · GitHub
Skip to content

bpo-28180: assume UTF-8 for Mac OS X PEP 538 tests - #2130

Merged
ncoghlan merged 3 commits into
python:masterfrom
ncoghlan:bpo-28180-fix-mac-os-x-test-errors
Jun 13, 2017
Merged

ncoghlan merged 3 commits into
python:masterfrom
ncoghlan:bpo-28180-fix-mac-os-x-test-errors

Conversation

@ncoghlan

Copy link
Copy Markdown
Contributor

No description provided.

@ncoghlan ncoghlan changed the title PEP 538: assume UTF-8 for Mac OS X tests bpo-28180: assume UTF-8 for Mac OS X PEP 538 tests Jun 12, 2017
@ncoghlan

Copy link
Copy Markdown
Contributor Author

@vstinner

Copy link
Copy Markdown
Member

test_locale_c_coercion still fail on macOS with this change. Only FS encoding is always utf-8 on macOS, the locale encoding is still impacted by LC_ALL, LC_CTYPE and LANG.

ncoghlan added 2 commits June 13, 2017 21:33
- clarify it's the default FS encoding we're checking
- don't skip the whole module when no target locales are available
- skip the explicit LANG=UTF-8 behaviour for now
@ncoghlan

Copy link
Copy Markdown
Contributor Author

@ncoghlan
ncoghlan merged commit 4563099 into python:master Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants