{{ message }}
gh-73180: Chain exceptions rather than dropping the old exception. - #2072
Open
serhiy-storchaka wants to merge 4 commits into
Open
serhiy-storchaka wants to merge 4 commits into
serhiy-storchaka wants to merge 4 commits into
Conversation
serhiy-storchaka
force-pushed
the
chain-exceptions
branch
from
June 12, 2017 11:27
162f054 to
8c5cb16
Compare
Member
|
Can you please rebase your change @serhiy-storchaka ? |
Member
Author
|
For |
serhiy-storchaka
force-pushed
the
chain-exceptions
branch
from
November 6, 2017 16:41
8c5cb16 to
d69a996
Compare
|
This PR is stale because it has been open for 30 days with no activity. |
MaxwellDupre
approved these changes
Mar 17, 2022
MaxwellDupre
left a comment
Contributor
There was a problem hiding this comment.
Ran test suite and got:
401 tests OK.
Looks good.
|
This PR is stale because it has been open for 30 days with no activity. |
Member
|
The feature seems to be implemented so the PR probably should be closed. try:
raise Exception('first exception')
except:
raise Exception('second exception') |
Member
The PR title is misleading. The PR is to keep the previously overridden exception in a bunch of C functions: _ctypes_extend_error(), call_exc_trace(), call_trace_protected(). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Uh oh!
There was an error while loading. Please reload this page.