bpo-39791: Support file systems that cannot support non-ascii filenames. by jaraco · Pull Request #20681 · python/cpython · GitHub
Skip to content

bpo-39791: Support file systems that cannot support non-ascii filenames. - #20681

Merged
jaraco merged 1 commit into
python:masterfrom
jaraco:bugfix/39791-unicode-error
Jun 7, 2020
Merged

bpo-39791: Support file systems that cannot support non-ascii filenames.#20681
jaraco merged 1 commit into
python:masterfrom
jaraco:bugfix/39791-unicode-error

Conversation

@jaraco

@jaraco jaraco commented Jun 6, 2020 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Member

In that case, the test is skipped. Addressed issue reported here.

https://bugs.python.org/issue39791

Automerge-Triggered-By: @jaraco

@jaraco jaraco added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section needs backport to 3.9 skip news tests Tests in the Lib/test dir and removed awaiting core review labels Jun 6, 2020
@bedevere-bot

bedevere-bot commented Jun 6, 2020

Copy link
Copy Markdown

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 6, 2020
@jaraco jaraco added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 6, 2020
@bedevere-bot

bedevere-bot commented Jun 6, 2020

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @jaraco for commit 3b4108c 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 6, 2020
@jaraco

jaraco commented Jun 7, 2020

Copy link
Copy Markdown
Member Author

Tried to merge but can’t from here.

@jaraco
jaraco merged commit 2efe18b into python:master Jun 7, 2020
@miss-islington

miss-islington commented Jun 7, 2020

Copy link
Copy Markdown
Contributor

Thanks @jaraco for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Jun 7, 2020

Copy link
Copy Markdown

@jaraco: Please replace # with GH- in the commit message next time. Thanks!

@jaraco
jaraco deleted the bugfix/39791-unicode-error branch June 7, 2020 14:57
@bedevere-bot

bedevere-bot commented Jun 7, 2020

Copy link
Copy Markdown

GH-20695 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Jun 7, 2020
@miss-islington @jaraco
bpo-39791: Support file systems that cannot support non-ascii filenam…
71f5016 
…es (skipping tests in that case). (GH-20681)

(cherry picked from commit 2efe18b)

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
@bedevere-bot

bedevere-bot commented Jun 7, 2020

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jaraco @bedevere-bot @miss-islington @the-knights-who-say-ni