{{ message }}
bpo-18319: gettext() can retrieve a message even if a plural form exists#19869
Merged
ambv merged 4 commits intopython:mainfrom Jul 23, 2023
Merged
bpo-18319: gettext() can retrieve a message even if a plural form exists#19869ambv merged 4 commits intopython:mainfrom
ambv merged 4 commits intopython:mainfrom
Conversation
remilapeyre
approved these changes
Jun 9, 2020
| return message | ||
| try: | ||
| # if `message` has plural forms | ||
| tmsg = self._catalog[(message, self.plural(1))] |
There was a problem hiding this comment.
Suggested change
| tmsg = self._catalog[(message, self.plural(1))] | |
| return self._catalog[(message, self.plural(1))] |
taleinat
reviewed
Oct 18, 2020
| if self._fallback: | ||
| return self._fallback.gettext(message) | ||
| return message | ||
| try: |
Contributor
There was a problem hiding this comment.
I suggest simply adding the following before the existing if tmsg is missing: ... block:
if tmsg is missing:
tmsg = self._catalog.get((message, self.plural(1)), missing)
|
Just noticed this annoying bug as well (via babel). It's impossible to work around without starting to mess around with message contexts (and I should NOT need to add garbage to my code (and pot files) because of this), so it would be great if this fix could get merged.. |
Contributor
|
Should this logic be also added to |
ambv
added
needs backport to 3.11
Contributor
|
Thanks @gbassiere for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Contributor
|
Thanks @gbassiere for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
GH-107107 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 23, 2023
…sts (pythonGH-19869) (cherry picked from commit 5463252) Co-authored-by: Gilles Bassière <gbassiere@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 23, 2023
…sts (pythonGH-19869) (cherry picked from commit 5463252) Co-authored-by: Gilles Bassière <gbassiere@gmail.com>
ambv
pushed a commit
that referenced
this pull request
Jul 23, 2023
jtcave
pushed a commit
to jtcave/cpython
that referenced
this pull request
Jul 23, 2023
mementum
pushed a commit
to mementum/cpython
that referenced
this pull request
Jul 23, 2023
serhiy-storchaka
pushed a commit
that referenced
this pull request
Aug 16, 2023
m-aciek
added a commit
to m-aciek/attributivegettext
that referenced
this pull request
Feb 16, 2024
After python/cpython#19869 PR merged gettext() can lookup plural() which is not set when constructor argument (file handler) is unspecified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's say you have this in your code:
and elsewhere this :
GNU gettext tools extracts these as the same unique message and sensibly creates a pluralized entry in the PO file.
In the Python gettext module, when the MO file is parsed, a singular 'egg' will be stored as:
whereas a pluralized 'egg' is stored as:
As a consequence,
gettext('egg')fail to retrieve translations and you have to resort tongettext('egg', 'eggs', 1)which is odd.My suggestion is simply to modify
gettext()so that is looks forcatalog[('egg', 0)]ifcatalog['egg']didn't match.https://bugs.python.org/issue18319