Deleted extra line by kenplix · Pull Request #19834 · python/cpython · GitHub
Skip to content

Deleted extra line - #19834

Closed
kenplix wants to merge 1 commit into
python:masterfrom
kenplix:patch-1
Closed

kenplix wants to merge 1 commit into
python:masterfrom
kenplix:patch-1

Conversation

@kenplix

@kenplix kenplix commented May 1, 2020

Copy link
Copy Markdown

In 3.8 Python, multiprocessing does not work because the module signal is empty

My solution is:
in signal/init.py add line
from _signal import *

In 3.8 Python,  multiprocessing does not work because the module signal is empty

My solution is:
in signal/__init__.py add line 
from _signal import *
@the-knights-who-say-ni

Copy link
Copy Markdown

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change breaks all CI. It is wrong.

@bedevere-bot

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@vstinner

vstinner commented May 1, 2020

Copy link
Copy Markdown
Member

I don't understand which issue you are trying to solve.

@csabella

csabella commented May 28, 2020

Copy link
Copy Markdown
Contributor

@csabella csabella closed this May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants