Add missing sys import to socket_helper.py by pablogsal · Pull Request #19791 · python/cpython · GitHub
Skip to content

Add missing sys import to socket_helper.py - #19791

Merged
pablogsal merged 1 commit into
python:masterfrom
pablogsal:missing_sys
Apr 29, 2020
Merged

Add missing sys import to socket_helper.py#19791
pablogsal merged 1 commit into
python:masterfrom
pablogsal:missing_sys

Conversation

@pablogsal

@pablogsal pablogsal commented Apr 29, 2020

Copy link
Copy Markdown
Member

No description provided.

@pablogsal
pablogsal requested a review from vstinner April 29, 2020 10:57
@pablogsal

pablogsal commented Apr 29, 2020

Copy link
Copy Markdown
Member Author

@pablogsal pablogsal self-assigned this Apr 29, 2020
@pablogsal pablogsal mentioned this pull request Apr 29, 2020
Merged
@pablogsal

pablogsal commented Apr 29, 2020

Copy link
Copy Markdown
Member Author

I am merging this as is causing a lot of buildbot failures and is a trivial fix.

@pablogsal
pablogsal merged commit 5089bcd into python:master Apr 29, 2020
@pablogsal
pablogsal deleted the missing_sys branch April 29, 2020 11:32
@serhiy-storchaka

serhiy-storchaka commented Apr 30, 2020

Copy link
Copy Markdown
Member

Thank you Pablo.

@vstinner

vstinner commented Apr 30, 2020

Copy link
Copy Markdown
Member

I ran pyflakes to check imports and created https://bugs.python.org/issue40443 as a follow-up :-)

@vstinner

vstinner commented May 1, 2020

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner Awaiting requested review from vstinner
@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees

@pablogsal pablogsal

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pablogsal @serhiy-storchaka @vstinner @the-knights-who-say-ni @bedevere-bot