bpo-40370: Pass the same compile args and link args as the interpreter in test_peg_generator by pablogsal · Pull Request #19674 · python/cpython · GitHub
Skip to content

bpo-40370: Pass the same compile args and link args as the interpreter in test_peg_generator - #19674

Merged
pablogsal merged 5 commits into
python:masterfrom
pablogsal:bpo-40370
Apr 23, 2020
Merged

bpo-40370: Pass the same compile args and link args as the interpreter in test_peg_generator#19674
pablogsal merged 5 commits into
python:masterfrom
pablogsal:bpo-40370

Conversation

@pablogsal

@pablogsal pablogsal commented Apr 23, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@pablogsal pablogsal added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section and removed CLA signed labels Apr 23, 2020
@bedevere-bot

bedevere-bot commented Apr 23, 2020

Copy link
Copy Markdown

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 23, 2020
@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 23, 2020
@bedevere-bot

bedevere-bot commented Apr 23, 2020

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit c19a7eb 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 23, 2020
lysnikolaou
lysnikolaou reviewed Apr 23, 2020
View reviewed changes

@lysnikolaou lysnikolaou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was really just about to push exactly this.

Comment thread Tools/peg_generator/pegen/build.py Outdated
@pablogsal @lysnikolaou
Update Tools/peg_generator/pegen/build.py
2dac618 
Co-Authored-By: Lysandros Nikolaou <lisandrosnik@gmail.com>
@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 23, 2020
@bedevere-bot

bedevere-bot commented Apr 23, 2020

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 2dac618 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 23, 2020
@lysnikolaou

lysnikolaou commented Apr 23, 2020

Copy link
Copy Markdown
Member

Windows CI fails with LINK : fatal error LNK1181: cannot open input file 'None.obj', when compiling the extension in test_peg_generator.

@pablogsal
pablogsal marked this pull request as draft April 23, 2020 11:37
@pablogsal

pablogsal commented Apr 23, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

Windows CI fails with LINK : fatal error LNK1181: cannot open input file 'None.obj', when compiling the extension in test_peg_generator.

Yeah, no idea where that is coming from :(

Is because in windows the sysconfig flags will return None.

@pablogsal
pablogsal requested a review from lysnikolaou April 23, 2020 12:16
@pablogsal
pablogsal marked this pull request as ready for review April 23, 2020 12:16
@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 23, 2020
@bedevere-bot

bedevere-bot commented Apr 23, 2020

Copy link
Copy Markdown

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 23, 2020
@pablogsal pablogsal self-assigned this Apr 23, 2020
lysnikolaou
lysnikolaou approved these changes Apr 23, 2020
View reviewed changes

@lysnikolaou lysnikolaou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@pablogsal
pablogsal merged commit 9e6a131 into python:master Apr 23, 2020
@pablogsal
pablogsal deleted the bpo-40370 branch April 23, 2020 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lysnikolaou lysnikolaou lysnikolaou approved these changes

Assignees

@pablogsal pablogsal

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pablogsal @bedevere-bot @lysnikolaou @the-knights-who-say-ni