{{ message }}
bpo-40273: Reversible mappingproxy - #19513
Merged
rhettinger merged 3 commits intoMay 8, 2020
Merged
Conversation
Contributor
Author
brandtbucher
requested changes
Apr 14, 2020
brandtbucher
left a comment
brandtbucher
left a comment
Member
There was a problem hiding this comment.
Looks good! One tiny suggestion for the test:
Comment on lines
+774
to
+775
| del d['foo'] | ||
| r = reversed(self.mappingproxy(d)) |
Member
There was a problem hiding this comment.
I think creating the proxy before deleting the element makes sure that this is indeed an updating view:
Suggested change
| del d['foo'] | |
| r = reversed(self.mappingproxy(d)) | |
| mp = self.mappingproxy(d) | |
| del d['foo'] | |
| r = reversed(mp) |
Member
|
This should probably also get docs, similar to the ones for .. describe:: reversed(proxy)
Return a reversed iterator over the keys of the underlying mapping.
.. versionadded:: 3.9 |
rhettinger
reviewed
Apr 14, 2020
Contributor
There was a problem hiding this comment.
This needs a versionchanged entry in the main docs as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue40273