{{ message }}
bpo-39481: Make dataclasses.Field, contextvars.Token, ... - #19425
Merged
Conversation
... mailbox.MailBox, and mailbox._ProxyFile generic.
emmatyping
commented
Apr 7, 2020
1st1
reviewed
Apr 8, 2020
gvanrossum
reviewed
Apr 10, 2020
gvanrossum
left a comment
gvanrossum
left a comment
Member
There was a problem hiding this comment.
There's also another __class_getitem__, for contextvar, in this file. I think that one should also become GenericAlias.
gvanrossum
requested changes
Apr 10, 2020
gvanrossum
left a comment
gvanrossum
left a comment
Member
There was a problem hiding this comment.
Waiting for the docstring to be reverted and for the other class_getitem to link to GenericAlias.
Member
Author
|
Sorry for the delay, I'll get to this and #19427 a bit later today. |
Member
Author
|
I have made the requested changes; please review again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... mailbox.MailBox, and mailbox._ProxyFile generic.
https://bugs.python.org/issue39481