bpo-29535: Not all datetime objects are using hashing randomization by arigo · Pull Request #1937 · python/cpython · GitHub
Skip to content

bpo-29535: Not all datetime objects are using hashing randomization - #1937

Closed
arigo wants to merge 1 commit into
python:masterfrom
arigo:master
Closed

bpo-29535: Not all datetime objects are using hashing randomization#1937
arigo wants to merge 1 commit into
python:masterfrom
arigo:master

Conversation

@arigo

@arigo arigo commented Jun 4, 2017 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Security concern: pending feedback on issue bpo-29535, here is an update of the documentation. It should make it clear that not all datetime objects come with randomized hashes.

https://bugs.python.org/issue29535

@mention-bot

mention-bot commented Jun 4, 2017

Copy link
Copy Markdown

@serhiy-storchaka serhiy-storchaka changed the title Not all datetime objects are using hashing randomization (issue29535) bpo-29535: Not all datetime objects are using hashing randomization Mar 26, 2018
@serhiy-storchaka serhiy-storchaka added needs backport to 3.6 docs Documentation in the Doc dir labels Mar 26, 2018
abalkin
abalkin requested changes May 4, 2018
View reviewed changes

@abalkin abalkin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not clear what "some datetime objects" include. Is it some subset of date, time, datetime, timezone types or some instances of these types get randomized hash and some don't? If we are going to document the current implementation we should explain precisely which objects have deterministic hash and which don't.

@bedevere-bot

bedevere-bot commented May 4, 2018

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be put in the comfy chair!

@arigo

arigo commented May 6, 2018

Copy link
Copy Markdown
Contributor Author

@arigo arigo closed this May 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abalkin abalkin abalkin requested changes

Assignees

No one assigned

Labels

awaiting changes docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@arigo @mention-bot @bedevere-bot @abalkin @brettcannon @serhiy-storchaka @the-knights-who-say-ni