Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@BenjaminLiuPenrose

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Hi, I already signed CLA with my github account

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Closed bpo-40167 as a duplicate of an older bpo-35037 which has more info. Please update the PR as requested by @taleinat

You should specify -DMS_WIN64 for g++ to using MinGW-64 on Windows.

The original author hasn't picked this up again since my comments 1.5 years ago. I think we can consider them no longer interested.

Is anyone else interested in bringing this to completion? @jimboyeah?

This PR can be closed, it was superceded by gh-100137 which was merged 2 months ago.

@rgommers Thank you for pointing the duplicate out! Closing.