bpo-38597: Never statically link extension initialization code on Windows by zooba · Pull Request #18724 · python/cpython · GitHub
Skip to content

bpo-38597: Never statically link extension initialization code on Windows - #18724

Merged
zooba merged 1 commit into
python:masterfrom
zooba:bpo-38597
Mar 3, 2020
Merged

zooba merged 1 commit into
python:masterfrom
zooba:bpo-38597

Conversation

@zooba

@zooba zooba commented Mar 1, 2020

Copy link
Copy Markdown
Member

@zooba zooba added type-bug An unexpected behavior, bug, or error OS-windows needs backport to 3.7 labels Mar 1, 2020
@zooba
zooba requested a review from a team as a code owner March 1, 2020 15:05
@codecov

codecov Bot commented Mar 1, 2020

Copy link
Copy Markdown

@zware zware left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks basically fine to me, but I'm not familiar enough to really say yay or nay. Paging @eryksun :)

Comment thread Lib/distutils/_msvccompiler.py
@zooba
zooba merged commit ce3a498 into python:master Mar 3, 2020
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@zooba
zooba deleted the bpo-38597 branch March 3, 2020 00:04
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 3, 2020
…dows (pythonGH-18724)

(cherry picked from commit ce3a498)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-bot

Copy link
Copy Markdown

GH-18758 is a backport of this pull request to the 3.8 branch.

@miss-islington

Copy link
Copy Markdown
Contributor

Sorry, @zooba, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker ce3a4984089b8e0ce5422ca32d75ad057b008074 3.7

@bedevere-bot

Copy link
Copy Markdown

miss-islington pushed a commit that referenced this pull request Mar 3, 2020
miss-islington added a commit that referenced this pull request Mar 3, 2020
…dows (GH-18724)

(cherry picked from commit ce3a498)

Co-authored-by: Steve Dower <steve.dower@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OS-windows type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants