bpo-39648: Expand math.gcd() and math.lcm() to handle multiple arguments. by serhiy-storchaka · Pull Request #18604 · python/cpython · GitHub
Skip to content

bpo-39648: Expand math.gcd() and math.lcm() to handle multiple arguments. - #18604

Merged
mdickinson merged 4 commits into
python:masterfrom
serhiy-storchaka:math-gcd-lcm-multiarg
Feb 23, 2020
Merged

bpo-39648: Expand math.gcd() and math.lcm() to handle multiple arguments.#18604
mdickinson merged 4 commits into
python:masterfrom
serhiy-storchaka:math-gcd-lcm-multiarg

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Feb 22, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Feb 22, 2020
@serhiy-storchaka serhiy-storchaka changed the title Expand math.gcd() and math.lcm() to handle multiple arguments. bpo-39648: Expand math.gcd() and math.lcm() to handle multiple arguments. Feb 22, 2020
@codecov

codecov Bot commented Feb 22, 2020 •
edited
Loading

Copy link
Copy Markdown

mdickinson
mdickinson approved these changes Feb 23, 2020
View reviewed changes

@mdickinson mdickinson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; a couple of suggested wording tweaks in the documentation.

Comment thread Doc/library/math.rst Outdated
Comment thread Doc/library/math.rst Outdated
Comment thread Doc/library/math.rst Outdated
Comment thread Doc/library/math.rst Outdated
Comment thread Modules/mathmodule.c
@serhiy-storchaka @mdickinson
Apply suggestions from code review
88998f7 
Co-Authored-By: Mark Dickinson <dickinsm@gmail.com>
@mdickinson
mdickinson merged commit 559e7f1 into python:master Feb 23, 2020
@mdickinson

mdickinson commented Feb 23, 2020

Copy link
Copy Markdown
Member

Thanks, Serhiy!

@mdickinson mdickinson mentioned this pull request Feb 23, 2020
Closed
@serhiy-storchaka

serhiy-storchaka commented Feb 23, 2020

Copy link
Copy Markdown
Member Author

@serhiy-storchaka
serhiy-storchaka deleted the math-gcd-lcm-multiarg branch February 23, 2020 12:40
@sthagen sthagen mentioned this pull request Feb 23, 2020
Merged
@namannimmo10 namannimmo10 mentioned this pull request Feb 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@mdickinson mdickinson mdickinson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@serhiy-storchaka @mdickinson @the-knights-who-say-ni @bedevere-bot