gh-64383: Migrate builtins.vars and builtins.dir to Argument Clinic by shihai1991 · Pull Request #18512 · python/cpython · GitHub
Skip to content

gh-64383: Migrate builtins.vars and builtins.dir to Argument Clinic - #18512

Closed
shihai1991 wants to merge 2 commits into
python:mainfrom
shihai1991:bpo_20184
Closed

gh-64383: Migrate builtins.vars and builtins.dir to Argument Clinic#18512
shihai1991 wants to merge 2 commits into
python:mainfrom
shihai1991:bpo_20184

Conversation

@shihai1991

@shihai1991 shihai1991 commented Feb 15, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@shihai1991
shihai1991 requested a review from ncoghlan February 15, 2020 10:23
@codecov

codecov Bot commented Feb 15, 2020

Copy link
Copy Markdown

@JelleZijlstra

JelleZijlstra commented Apr 17, 2022

Copy link
Copy Markdown
Member

Sorry this had to wait for so long! If you're still interested, would you be able to fix the merge conflicts? Then I can review it and get it merged.

@shihai1991

shihai1991 commented Apr 19, 2022

Copy link
Copy Markdown
Member Author

Sorry this had to wait for so long! If you're still interested, would you be able to fix the merge conflicts? Then I can review it and get it merged.

Oh, Thanks. Give me some time to take a look. I forget the details already :(

hauntsaninja
hauntsaninja requested changes Feb 9, 2023
View reviewed changes

@hauntsaninja hauntsaninja left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes for fixing the conflicts, as per above

@bedevere-bot

bedevere-bot commented Feb 9, 2023

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@arhadthedev arhadthedev changed the title bpo-20184: Migrate builtins.vars and builtins.dir to Argument Clinic gh-64383: Migrate builtins.vars and builtins.dir to Argument Clinic Feb 13, 2023
@arhadthedev arhadthedev added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Feb 13, 2023
@arhadthedev

arhadthedev commented Feb 13, 2023

Copy link
Copy Markdown
Member

@larryhastings larryhastings mentioned this pull request Feb 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja requested changes
@ncoghlan ncoghlan Awaiting requested review from ncoghlan
@larryhastings larryhastings Awaiting requested review from larryhastings

Assignees

No one assigned

Labels

awaiting changes interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-argument-clinic

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@shihai1991 @JelleZijlstra @bedevere-bot @arhadthedev @hauntsaninja @serhiy-storchaka @the-knights-who-say-ni @ezio-melotti