bpo-39245: Switch to public API for Vectorcall by encukou · Pull Request #18460 · python/cpython · GitHub
Skip to content

bpo-39245: Switch to public API for Vectorcall - #18460

Merged
encukou merged 2 commits into
python:masterfrom
encukou:vectorcall-callsites
Feb 11, 2020
Merged

bpo-39245: Switch to public API for Vectorcall#18460
encukou merged 2 commits into
python:masterfrom
encukou:vectorcall-callsites

Conversation

@encukou

@encukou encukou commented Feb 11, 2020

Copy link
Copy Markdown
Member

Continuation of #17893

The NEWS entry was added there.

https://bugs.python.org/issue39245

Generated automatically with:

    for name in \
        PyObject_Vectorcall \
        Py_TPFLAGS_HAVE_VECTORCALL \
        PyObject_VectorcallMethod \
        PyVectorcall_Function \
        PyObject_CallOneArg \
        PyObject_CallMethodNoArgs \
        PyObject_CallMethodOneArg \
    ;
    do
        echo $name
        git grep -lwz _$name | xargs -0 sed -i "s/\b_$name\b/$name/g"
    done

    old=_PyObject_FastCallDict
    new=PyObject_VectorcallDict
    git grep -lwz $old | xargs -0 sed -i "s/\b$old\b/$new/g"
- Revert changes to in docs & news
- Revert changes to backcompat defines in headers
- Nudge misaligned comments

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov

codecov Bot commented Feb 11, 2020

Copy link
Copy Markdown

@encukou
encukou merged commit ffd9753 into python:master Feb 11, 2020
@encukou
encukou deleted the vectorcall-callsites branch February 11, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants