{{ message }}
bpo-39593: Adding an unit test of ctypes - #18424
Merged
Merged
Conversation
corona10
reviewed
Feb 10, 2020
vstinner
reviewed
May 27, 2020
Member
|
Oops, I had a pending comment that I never submitted! |
Member
Author
I always forget to submit too ; ) |
Member
Author
vstinner
reviewed
May 28, 2020
|
|
||
| data = PyBytes_AS_STRING(value); | ||
| size = strlen(data); /* XXX Why not Py_SIZE(value)? */ | ||
| /* bpo-39593: XXX Why not Py_SIZE(value)? */ |
Member
There was a problem hiding this comment.
I don't think that it's correct to add a test which indirectly specify the behavior and keep this comment which suggests to change the behavior.
I suggest to rewrite the comment to explain that we do use strlen() on purpose, rather than PyBytes_GET_SIZE() since we truncate characters after a null character on purpose. Keep the bpo number in the comment.
Member
Author
There was a problem hiding this comment.
Thanks, got it. I updated the description info, do you think it's clear enough?
vstinner
reviewed
May 28, 2020
Co-authored-by: Victor Stinner <vstinner@python.org>
Member
|
Thanks, merged. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue39593