bpo-39481: Implementation for PEP 585 by gvanrossum · Pull Request #18239 · python/cpython · GitHub
Skip to content

bpo-39481: Implementation for PEP 585 #18239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 78 commits into from
Apr 7, 2020
Merged

bpo-39481: Implementation for PEP 585 #18239

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
78 commits
Select commit Hold shift + click to select a range
d557a64
PEP 585 step 2: Write a Py_GenericAlias() function that returns origin
gvanrossum Jan 27, 2020
da33267
PEP 585 step 3: Add Py_GenericAlias() as __class_getitem__ to tuple, …
gvanrossum Jan 27, 2020
447fbe9
PEP 585 step 4: Write some tests
gvanrossum Jan 27, 2020
83e2ba2
Define a GenericAlias (proxy) object (with lots of TODOs still)
gvanrossum Jan 27, 2020
fb3e8d3
More tests
gvanrossum Jan 28, 2020
235180b
PEP 585 steps 5-6: Finish basic GenericAlias object and test
gvanrossum Jan 28, 2020
70f3abc
Fix bug with class methods
gvanrossum Jan 28, 2020
e4d1356
Define tp_new instead of tp_init
gvanrossum Jan 28, 2020
8f7a55e
Test that list[int][int] fails
gvanrossum Jan 28, 2020
f2ba2e5
Test that class L(list): pass; L[int] works
gvanrossum Jan 28, 2020
0af74d1
Implement PEP 585 for collections.deque and ... (#2)
emmatyping Jan 28, 2020
b264294
Respond to Serhiy's code review
gvanrossum Jan 28, 2020
0ddea56
📜🤖 Added by blurb_it.
blurb-it[bot] Jan 28, 2020
91edf1c
PEP 585 steps 7-8: Implement repr for GenericAlias (#1)
emmatyping Jan 29, 2020
6b1a218
Add static keyword to ga_repr_item (#3)
emmatyping Jan 29, 2020
ce21a96
Add GenericAlias to types.py
gvanrossum Jan 29, 2020
dbe67d0
Add test for types.py
gvanrossum Jan 29, 2020
15697f0
Fix tests that were sensitive to the presence of __class_getitem__
gvanrossum Jan 29, 2020
da15d43
Fix crash in repr(tuple[...]) -- call PyErr_Clear()
gvanrossum Jan 29, 2020
647cda8
Make re.Match, re.Pattern, and io.IOBase generic (#4)
emmatyping Jan 29, 2020
3824954
Restore parity between _io._IOBase and _pyio.IOBase
gvanrossum Jan 29, 2020
8aec6ae
Make contextlib.Abstract*ContextManager generic, with tests
gvanrossum Jan 29, 2020
58af183
WIP: Tweak test_typing.py to pass with the new definition of __orig_c…
gvanrossum Jan 29, 2020
8da0a08
Rename __parameters__ to __args__
gvanrossum Jan 29, 2020
eaecacb
Rename parameters to args
gvanrossum Jan 29, 2020
98d479f
Properly implement __parameters__ as the tuple of args that are type …
gvanrossum Jan 29, 2020
82bc806
Set __orig_class__ if possible when instantiating
gvanrossum Jan 29, 2020
2567ce3
WIP: Implement ga_getitem so list[T][int] -> list[int]
gvanrossum Jan 30, 2020
4f2ced6
Exclude duplicates from __parameters__
gvanrossum Jan 30, 2020
2c25fb0
Implement ga_getitem properly, with tests
gvanrossum Jan 31, 2020
9ed17ef
Implement == and != for GA
gvanrossum Jan 31, 2020
bb9a11f
Make collections.abc.* generic (#5)
emmatyping Jan 31, 2020
6d3f535
Make isinstance and issubclass error for GenericAlias (#6)
emmatyping Jan 31, 2020
4b3ecf2
Fix two more AssertIs calls in test_typing.py
gvanrossum Jan 31, 2020
2df602b
Admit defeat -- comment out two expected TypeErrors in test_extended_…
gvanrossum Jan 31, 2020
eede65a
Fix whitespace to satisfy patchcheck.py
gvanrossum Jan 31, 2020
2b22f6e
Fix test_site.py
gvanrossum Jan 31, 2020
065a032
Better way to fix test_site.py: don't import types from collections
gvanrossum Jan 31, 2020
baf9b32
Use Py_ssize_t instead of int for indexing (#8)
emmatyping Jan 31, 2020
9915ba2
GenericAlias pickle support (#9)
emmatyping Feb 5, 2020
4e1da19
Make type generic (#7)
emmatyping Feb 5, 2020
8926f7a
Remove a completed TODO comment
gvanrossum Feb 5, 2020
7b1ad20
Remove extraneous whitespace. (#10)
emmatyping Feb 5, 2020
a05d9ae
Do not make IOBase generic (#11)
emmatyping Feb 7, 2020
d4a372b
Remove __class_getitem__ from _pyio.py too; and don't test for IOBase
gvanrossum Feb 7, 2020
c534f67
Merge branch 'master' into pep585
gvanrossum Feb 10, 2020
2f94a36
Make types.MappingProxyType generic (#13)
emmatyping Feb 25, 2020
3da2797
Reword isinstance/subclass checks (#12)
emmatyping Feb 25, 2020
13d8d6d
Fix test_types (mappingproxy now has a __class_getitem__ method)
gvanrossum Feb 25, 2020
43a97b9
Merge remote-tracking branch 'upstream/master' into pep585
gvanrossum Feb 25, 2020
4783c2e
Convert some already generic things to GenericAlias to be consistent …
emmatyping Feb 25, 2020
e50136d
Make __parameters__ lazy (#15)
emmatyping Feb 25, 2020
0192986
Fix failing test_doctest -- we now find 821 tests
gvanrossum Feb 25, 2020
b80b077
Don't import types in os.py -- it breaks test_site.py
gvanrossum Feb 25, 2020
3bc4e12
Move GenericAlias definition to its own file
gvanrossum Mar 14, 2020
f658a64
Add a hash function to GenericAlias
gvanrossum Mar 14, 2020
bfd6342
Make Union[list[T], int] work
gvanrossum Mar 15, 2020
7919fa2
Add GenericAlias to Windows build (#16)
emmatyping Mar 16, 2020
854fa99
Merge remote-tracking branch 'upstream/master' into pep585
gvanrossum Mar 16, 2020
728084a
Run CI on PRs for pep585 branch
gvanrossum Mar 18, 2020
29130ab
Merge branch 'master' into pep585
gvanrossum Mar 29, 2020
ddbce27
Add docstring for GenericAlias (#17)
emmatyping Mar 30, 2020
4db065d
Remove unneeded _GenericAlias definition from collections/__init__.py
gvanrossum Mar 31, 2020
e14625f
Make is_typevar() harder to fool
gvanrossum Apr 5, 2020
76c0805
Rewrite ga_repr_item() to honor exceptions
gvanrossum Apr 5, 2020
128aacb
Use __class_getitem__ = classmethod(GenericAlias)
gvanrossum Apr 5, 2020
94f4095
Update Objects/genericaliasobject.c
gvanrossum Apr 5, 2020
79f4170
Apply suggestions from code review
gvanrossum Apr 5, 2020
f6f5b81
Use PyTuple_GET_SIZE
gvanrossum Apr 5, 2020
99cac83
Use PyErr_SetString correctly
gvanrossum Apr 5, 2020
6044934
Fix test failure (setattr may raise TypeError)
gvanrossum Apr 5, 2020
355d267
Propagate errors from is_typevar()
gvanrossum Apr 6, 2020
95b3c2a
Use PyObject_Str(qualname)
gvanrossum Apr 6, 2020
13d3742
Merge remote-tracking branch 'upstream/master' into pep585
gvanrossum Apr 6, 2020
d3839ea
Delete mention of pep585 branch in GitHub workflow
gvanrossum Apr 6, 2020
31fd842
Move Py_GenericAlias* to genericaliasobject.h
gvanrossum Apr 7, 2020
6bad315
Merge remote-tracking branch 'upstream/master' into pep585
gvanrossum Apr 7, 2020
cdb46c3
Add Py_GenericAlias[Type] to PC/python3.ref
gvanrossum Apr 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move GenericAlias definition to its own file
  • Loading branch information
@gvanrossum
gvanrossum committed Mar 14, 2020
commit 3bc4e127cc1807100c4cd68a6815c91c32c2289a
1 change: 1 addition & 0 deletions Makefile.pre.in
View file
Open in desktop
Loading