bpo-39184: Add audit events to command execution functions in os and pty modules by gousaiyang · Pull Request #17824 · python/cpython · GitHub
Skip to content

bpo-39184: Add audit events to command execution functions in os and pty modules - #17824

Merged
zooba merged 3 commits into
python:masterfrom
gousaiyang:bpo-39184
Feb 5, 2020
Merged

bpo-39184: Add audit events to command execution functions in os and pty modules#17824
zooba merged 3 commits into
python:masterfrom
gousaiyang:bpo-39184

Conversation

@gousaiyang

@gousaiyang gousaiyang commented Jan 4, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Add audit events to the following functions:

  • os.exec*
  • os.spawn*
  • os.posix_spawn*
  • os.startfile
  • pty.spawn

https://bugs.python.org/issue39184

https://bugs.python.org/issue39184

@the-knights-who-say-ni

the-knights-who-say-ni commented Jan 4, 2020

Copy link
Copy Markdown

@terryjreedy
terryjreedy requested review from zooba and removed request for 1st1, asvetlov, ethanfurman and terryjreedy January 8, 2020 21:11
@terryjreedy

terryjreedy commented Jan 8, 2020

Copy link
Copy Markdown
Member

I was about to close this and tell you to start over with a new PR, but you seem to have corrected it. In the future, do not hit the green [Make Pull Request] button unless the list of commits only has your commits and not those of others. Also, fix the list of suggested reviewers when needed.

@gousaiyang

gousaiyang commented Jan 8, 2020

Copy link
Copy Markdown
Contributor Author

Sorry about this, the review request was automatically triggered by the system. I messed up with this branch (should not fetch changes by others) and fixed it by force push.

@zooba

zooba commented Feb 5, 2020

Copy link
Copy Markdown
Member

Thanks! These look great!

@zooba
zooba merged commit 95f6001 into python:master Feb 5, 2020
@miss-islington

miss-islington commented Feb 5, 2020

Copy link
Copy Markdown
Contributor

Thanks @gousaiyang for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Feb 5, 2020

Copy link
Copy Markdown
Contributor

Sorry @gousaiyang and @zooba, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 95f60010219e142a436fae18e1695cbc45407afe 3.8

@miss-islington

miss-islington commented Feb 5, 2020

Copy link
Copy Markdown
Contributor

Thanks @gousaiyang for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 5, 2020
@gousaiyang @miss-islington
bpo-39184: Add audit events to command execution functions in os and …
b46dd9b 
…pty modules (pythonGH-17824)

(cherry picked from commit 95f6001)

Co-authored-by: Saiyang Gou <gousaiyang@163.com>
@bedevere-bot

bedevere-bot commented Feb 5, 2020

Copy link
Copy Markdown

@gousaiyang
gousaiyang deleted the bpo-39184 branch February 5, 2020 00:22
miss-islington added a commit that referenced this pull request Feb 5, 2020
@miss-islington @gousaiyang
bpo-39184: Add audit events to command execution functions in os and …
3498ac5 
…pty modules (GH-17824)

(cherry picked from commit 95f6001)

Co-authored-by: Saiyang Gou <gousaiyang@163.com>
@gousaiyang gousaiyang mannequin mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba Awaiting requested review from zooba

Assignees

@zooba zooba

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gousaiyang @the-knights-who-say-ni @terryjreedy @zooba @miss-islington @bedevere-bot