bpo-39082: Fix: AsyncMock is unable to correctly patch static/class methods by czardoz · Pull Request #17717 · python/cpython · GitHub
Skip to content

bpo-39082: Fix: AsyncMock is unable to correctly patch static/class methods - #17717

Closed
czardoz wants to merge 1 commit into
python:masterfrom
czardoz:master
Closed

czardoz wants to merge 1 commit into
python:masterfrom
czardoz:master

Conversation

@czardoz

@czardoz czardoz commented Dec 27, 2019

Copy link
Copy Markdown
Contributor

Essentially, patching a coroutinefunction decorated with @classmethod or @staticmethod does not currently work correctly. Instead of creating an AsyncMock(), patch() uses a Mock(), which fails when it's awaited on.

https://bugs.python.org/issue39082

@the-knights-who-say-ni

Copy link
Copy Markdown

@lisroach

Copy link
Copy Markdown
Contributor

I think this implementation is good, I am wondering if @tirkarthi's suggestion of:

if hasattr(obj, '__func__'):
     obj = getattr(obj, '__func__')

wouldn't be better, as it might cover more use cases. It might have the potential of helping out with the backwards compatibility issue with 3.6 in testing-cabal/mock#476. What do you think Karthikeyan?

@cjw296

cjw296 commented Jan 24, 2020

Copy link
Copy Markdown
Contributor

@czardoz - please can you add a NEWS entry for this?

@tirkarthi

Copy link
Copy Markdown
Member

I would prefer accessing function from __func__ only for classmethod and staticmethod to keep the scope limited as per the report. I must admit that I found __func__ having the correct function while debugging initially as there is difference in the attribute lookup precedence. I don't think this will have compatibility issue with 3.6. Am I missing something here?

@cjw296

cjw296 commented Jan 24, 2020

Copy link
Copy Markdown
Contributor

@czardoz - can you add a NEWS entry for this please, I'd like to merge it :-)

@cjw296

cjw296 commented Jan 24, 2020

Copy link
Copy Markdown
Contributor

Wrong way round, closing this in favour of #18116.

@cjw296 cjw296 closed this Jan 24, 2020
@cjw296

cjw296 commented Jan 24, 2020

Copy link
Copy Markdown
Contributor

@tirkarthi - I think I'm fine with the __func__ check, where would you see this causing problems?

@tirkarthi

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants