[3.8] bpo-38546: multiprocessing tests stop the resource tracker (GH-17641) by vstinner · Pull Request #17647 · python/cpython · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions Lib/multiprocessing/resource_tracker.py
25 changes: 25 additions & 0 deletions Lib/multiprocessing/util.py
Original file line number Diff line number Diff line change
Expand Up @@ -439,3 +439,28 @@ def close_fds(*fds):
"""Close each file descriptor given as an argument"""
for fd in fds:
os.close(fd)


def _cleanup_tests():
"""Cleanup multiprocessing resources when multiprocessing tests
completed."""

from test import support

# cleanup multiprocessing
process._cleanup()

# Stop the ForkServer process if it's running
from multiprocessing import forkserver
forkserver._forkserver._stop()

# Stop the ResourceTracker process if it's running
from multiprocessing import resource_tracker
resource_tracker._resource_tracker._stop()

# bpo-37421: Explicitly call _run_finalizers() to remove immediately
# temporary directories created by multiprocessing.util.get_temp_dir().
_run_finalizers()
support.gc_collect()

support.reap_children()
11 changes: 1 addition & 10 deletions Lib/test/_test_multiprocessing.py
Original file line number Diff line number Diff line change
Expand Up @@ -5673,16 +5673,7 @@ def tearDownModule():
if need_sleep:
time.sleep(0.5)

multiprocessing.process._cleanup()

# Stop the ForkServer process if it's running
from multiprocessing import forkserver
forkserver._forkserver._stop()

# bpo-37421: Explicitly call _run_finalizers() to remove immediately
# temporary directories created by multiprocessing.util.get_temp_dir().
multiprocessing.util._run_finalizers()
test.support.gc_collect()
multiprocessing.util._cleanup_tests()

remote_globs['setUpModule'] = setUpModule
remote_globs['tearDownModule'] = tearDownModule
12 changes: 1 addition & 11 deletions Lib/test/test_concurrent_futures.py
Original file line number Diff line number Diff line change
Expand Up @@ -1306,17 +1306,7 @@ def setUpModule():

def tearDownModule():
test.support.threading_cleanup(*_threads_key)
test.support.reap_children()

# cleanup multiprocessing
multiprocessing.process._cleanup()
# Stop the ForkServer process if it's running
from multiprocessing import forkserver
forkserver._forkserver._stop()
# bpo-37421: Explicitly call _run_finalizers() to remove immediately
# temporary directories created by multiprocessing.util.get_temp_dir().
multiprocessing.util._run_finalizers()
test.support.gc_collect()
multiprocessing.util._cleanup_tests()


if __name__ == "__main__":
Expand Down