{{ message }}
Conversation
|
@arp11, thanks for your PR! By analyzing the history of the files in this pull request, we identified @loewis, @freddrake and @Yhg1s to be potential reviewers. |
BoboTiG
suggested changes
Jul 30, 2018
BoboTiG
left a comment
BoboTiG
left a comment
Contributor
There was a problem hiding this comment.
Hello,
Thank you for the patch. I locally checked and it is working fine.
Could you update the PR to include the news file as well?
| dom, orig, c1, c2, c3, frag = self._create_fragment_test_nodes() | ||
| written = StringIO() | ||
| frag.writexml(writer=written, indent=' ', addindent='-', newl=':') | ||
| self.assertEquals(written.getvalue(), ' foo: bar: bat:') |
Contributor
There was a problem hiding this comment.
Use self.assertEqual() (without the trailing s).
BoboTiG
suggested changes
Jul 30, 2018
| dom.unlink() | ||
|
|
||
| def testWriteXMLChildFragment(self): | ||
| dom, orig, c1, c2, c3, frag = self._create_fragment_test_nodes() |
Contributor
There was a problem hiding this comment.
You could delete unused vars by using dom, *_, frag = ....
Member
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds writexml method as well as a test to make sure it works. Since there was no attribute previously, the only behavior change is if a client introspects the available attributes on this node type specifically. There seems to be no other test coverage for writexml whatsoever.
https://bugs.python.org/issue9883