Added link to zlib v1.1.3 vulnerability by nosahama · Pull Request #17156 · python/cpython · GitHub
Skip to content

Added link to zlib v1.1.3 vulnerability - #17156

Merged
Yhg1s merged 1 commit into
python:masterfrom
nosahama:patch-1
Jan 3, 2020
Merged

Yhg1s merged 1 commit into
python:masterfrom
nosahama:patch-1

Conversation

@nosahama

Copy link
Copy Markdown
Contributor

This change adds a link to the vulnerability of the zlib v1.1.3 library (double-free vulnerability). In my own opinion, i feel some curious people might find it handy.

@the-knights-who-say-ni

Copy link
Copy Markdown

@brandtbucher

brandtbucher commented Nov 14, 2019

Copy link
Copy Markdown
Member

Thanks for your time @nosahama, and welcome to CPython!

I assume that you've seen the bot's message about the CLA?

@brandtbucher brandtbucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this is helpful. One minor comment:

Comment thread Doc/library/zlib.rst Outdated
@nosahama

Copy link
Copy Markdown
Contributor Author

Thanks for your time @nosahama, and welcome to CPython!

I assume that you've seen the bot's message about the CLA?

I did that already, i don't know what it's not showing up, maybe eventual consistency 😅

@brandtbucher

Copy link
Copy Markdown
Member

Yeah, give it a business day or two. As I understand it, they're processed manually by a human at the PSF.

This change adds a link to the vulnerability of the `zlib v1.1.3` library (double-free vulnerability). In my own opinion, i feel some curious people might find it handy.
@brandtbucher

Copy link
Copy Markdown
Member

CC @Yhg1s

@brandtbucher brandtbucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Yhg1s
Yhg1s merged commit b789202 into python:master Jan 3, 2020
@nosahama
nosahama deleted the patch-1 branch January 4, 2020 20:28
@brandtbucher

Copy link
Copy Markdown
Member

shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants