Fix spelling of patching in wave.py by micha2718l · Pull Request #17009 · python/cpython · GitHub
Skip to content

Fix spelling of patching in wave.py#17009

Merged
zware merged 1 commit into
python:masterfrom
micha2718l:waveLib_spelling_fix-pathing-patching
Nov 5, 2019
Merged

Fix spelling of patching in wave.py#17009
zware merged 1 commit into
python:masterfrom
micha2718l:waveLib_spelling_fix-pathing-patching

Conversation

@micha2718l

@micha2718l micha2718l commented Oct 31, 2019

Copy link
Copy Markdown
Contributor

This PR fixes the spelling of the word patching in the wave module.
pathing -> patching

@the-knights-who-say-ni

the-knights-who-say-ni commented Oct 31, 2019

Copy link
Copy Markdown

@brandtbucher brandtbucher added skip issue skip news docs Documentation in the Doc dir labels Oct 31, 2019
@brandtbucher

brandtbucher commented Oct 31, 2019

Copy link
Copy Markdown
Member

Thanks for your time @micha2718l, and welcome to CPython! 😎

brandtbucher
brandtbucher approved these changes Oct 31, 2019
View reviewed changes

@brandtbucher brandtbucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good change to me! I assume that you've seen the bot's message about the CLA?

@micha2718l

micha2718l commented Oct 31, 2019

Copy link
Copy Markdown
Contributor Author

This looks like a good change to me! I assume that you've seen the bot's message about the CLA?

Good to hear!
I did, I followed the steps and filled it out, though the check yourself link still says not signed. I assume it is taking a bit of time to get through the system?

@brandtbucher

brandtbucher commented Oct 31, 2019

Copy link
Copy Markdown
Member

Yeah, as I understand it, it's checked by a human at the PSF. Just give it a full business day and the label should change.

The good news is, you only have to do this once. So future contributions should be easier!

@zware zware merged commit 25fa3ec into python:master Nov 5, 2019
@miss-islington

miss-islington commented Nov 5, 2019

Copy link
Copy Markdown
Contributor

Thanks @micha2718l for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 5, 2019
@micha2718l @miss-islington
Fix a typo in wave module docstring (pythonGH-17009)
90adb25 
s/pathing/patching/
(cherry picked from commit 25fa3ec)

Co-authored-by: Michael Haas <micha2718l@gmail.com>
@bedevere-bot

bedevere-bot commented Nov 5, 2019

Copy link
Copy Markdown

GH-17054 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 5, 2019
@micha2718l @miss-islington
Fix a typo in wave module docstring (pythonGH-17009)
0dc9604 
s/pathing/patching/
(cherry picked from commit 25fa3ec)

Co-authored-by: Michael Haas <micha2718l@gmail.com>
@bedevere-bot

bedevere-bot commented Nov 5, 2019

Copy link
Copy Markdown

GH-17055 is a backport of this pull request to the 3.7 branch.

@zware

zware commented Nov 5, 2019

Copy link
Copy Markdown
Member

miss-islington added a commit that referenced this pull request Nov 5, 2019
@miss-islington @micha2718l
Fix a typo in wave module docstring (GH-17009)
1f9148b 
s/pathing/patching/
(cherry picked from commit 25fa3ec)

Co-authored-by: Michael Haas <micha2718l@gmail.com>
miss-islington added a commit that referenced this pull request Nov 5, 2019
@miss-islington @micha2718l
Fix a typo in wave module docstring (GH-17009)
e8bad63 
s/pathing/patching/
(cherry picked from commit 25fa3ec)

Co-authored-by: Michael Haas <micha2718l@gmail.com>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@micha2718l
Fix a typo in wave module docstring (pythonGH-17009)
0144c00 
s/pathing/patching/
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@micha2718l @shihai1991
Fix a typo in wave module docstring (pythonGH-17009)
e10a2ca 
s/pathing/patching/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zware zware zware approved these changes
@brandtbucher brandtbucher brandtbucher approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@micha2718l @the-knights-who-say-ni @brandtbucher @miss-islington @bedevere-bot @zware