bpo-30456: DOC: 2to3: fix example for duplicates in second argument of isinstance by eli-b · Pull Request #1699 · python/cpython · GitHub
Skip to content

bpo-30456: DOC: 2to3: fix example for duplicates in second argument of isinstance - #1699

Merged
berkerpeksag merged 2 commits into
python:masterfrom
eli-b:patch-1
Jul 24, 2017
Merged

berkerpeksag merged 2 commits into
python:masterfrom
eli-b:patch-1

Conversation

@eli-b

@eli-b eli-b commented May 21, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@mention-bot

Copy link
Copy Markdown

@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@eli-b eli-b changed the title 2to3: fix example for duplicates in second argument of isinstance DOC: 2to3: fix example for duplicates in second argument of isinstance May 21, 2017
@eli-b eli-b changed the title DOC: 2to3: fix example for duplicates in second argument of isinstance bpo-30456: DOC: 2to3: fix example for duplicates in second argument of isinstance May 24, 2017

@DimitrisJim DimitrisJim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though isinstance(x, (int)) is equivalent to isinstance(x, int) I can see how this might be confusing. Adding the other example also helps imho.

@berkerpeksag
berkerpeksag merged commit 26248ef into python:master Jul 24, 2017
@berkerpeksag

Copy link
Copy Markdown
Member

berkerpeksag pushed a commit to berkerpeksag/cpython that referenced this pull request Nov 23, 2017
berkerpeksag added a commit that referenced this pull request Nov 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants