{{ message }}
ENH: 🐍 snake#1686
Closed
tacaswell wants to merge 1 commit intopython:masterfrom
Hidden character warning
The head ref may contain hidden characters: "enh_\ud83d\udc0d_snek"
Closed
Conversation
Member
|
I hope this is just a joke -- this shouldn't be merged. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Special case the identifier validation to allow 🐍 to be used in
identifiers
This works in the terminal (assuming you have the right fonts, showing both with and without mark up as the 🐍 do not render for me in the escaped code)
(bleeding) ✔ ~
18:38 $ python
Python 3.7.0a0 (heads/enh_🐍_snek:2bfe3d18dad, May 20 2017, 18:32:35)
[GCC 6.3.1 20170306] on linux
Type "help", "copyright", "credits" or "license" for more information.
(bleeding) ✔ ~
It also works in the jupyter notebook (again assuming you have the right fonts)