[3.7] bpo-38243, xmlrpc.server: Escape the server_title (GH-16373) by miss-islington · Pull Request #16440 · python/cpython · GitHub
Skip to content

[3.7] bpo-38243, xmlrpc.server: Escape the server_title (GH-16373) #16440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 1 commit into from
Sep 27, 2019
Merged

[3.7] bpo-38243, xmlrpc.server: Escape the server_title (GH-16373) #16440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions Lib/test/test_docxmlrpc.py
View file
Open in desktop
3 changes: 2 additions & 1 deletion Lib/xmlrpc/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ def export_add(self, x, y):
from http.server import BaseHTTPRequestHandler
from functools import partial
from inspect import signature
import html
import http.server
import socketserver
import sys
Expand Down Expand Up @@ -894,7 +895,7 @@ def generate_html_documentation(self):
methods
)

return documenter.page(self.server_title, documentation)
return documenter.page(html.escape(self.server_title), documentation)

class DocXMLRPCRequestHandler(SimpleXMLRPCRequestHandler):
"""XML-RPC and documentation request handler class.
Expand Down
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Security/2019-09-25-13-21-09.bpo-38243.1pfz24.rst
View file
Open in desktop