{{ message }}
bpo-34533: Remove all static state from _csv module - #16078
Closed
eduardo-elizondo wants to merge 3 commits into
Closed
eduardo-elizondo wants to merge 3 commits into
eduardo-elizondo wants to merge 3 commits into
Conversation
Contributor
Author
Member
|
The PoC/WIP implementation of PEP 573 should do this plus also remove reliance |
ericsnowcurrently
self-requested a review
September 13, 2019 11:10
Contributor
Author
|
Yup! PEP573 should be the long term solution for getting the module state in C Extensions. We can always go back and update this module once the PEP is finalized. On that note, I have a couple of comments/questions that I've been meaning to post in capi-sig about PEP573. I should prioritize that as well :-) For now though, this should be ready to be merged as is (pending any in-line comments reviewers might have). |
eduardo-elizondo
changed the title
Member
|
Sorry, for the delay, @eduardo-elizondo. I plan on taking a look next Friday. |
encukou
added a commit
to encukou/cpython
that referenced
this pull request
May 19, 2020
See: python#16078 This is slightly nicer. Co-authored-by: Eddie Elizondo <eduardo.elizondorueda@gmail.com>
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jun 4, 2020
See: python#16078 This is slightly nicer. Co-authored-by: Eddie Elizondo <eduardo.elizondorueda@gmail.com>
encukou
added a commit
to encukou/cpython
that referenced
this pull request
Oct 20, 2020
Uses code from: python#16078 Co-authored-by: Marcel Plch <gmarcel.plch@gmail.com> Co-authored-by: Eddie Elizondo <eduardo.elizondorueda@gmail.com> Co-authored-by: Hai Shi <shihai1992@gmail.com>
Member
|
Here is my attempt: #22838 |
encukou
added a commit
to encukou/cpython
that referenced
this pull request
Nov 10, 2020
Uses code from: python#16078 Co-authored-by: Marcel Plch <gmarcel.plch@gmail.com> Co-authored-by: Eddie Elizondo <eduardo.elizondorueda@gmail.com> Co-authored-by: Hai Shi <shihai1992@gmail.com>
encukou
added a commit
that referenced
this pull request
Dec 15, 2020
Member
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
Uses code from: python#16078 Co-authored-by: Marcel Plch <gmarcel.plch@gmail.com> Co-authored-by: Eddie Elizondo <eduardo.elizondorueda@gmail.com> Co-authored-by: Hai Shi <shihai1992@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add all the changes needed to make _csv compatible with PEP384 as well as removing all static state from it
https://bugs.python.org/issue34533