bpo-37409: Fix ImportWarning regarding __spec__ and __package__ being None by tirkarthi · Pull Request #16003 · python/cpython · GitHub
Skip to content

bpo-37409: Fix ImportWarning regarding __spec__ and __package__ being None - #16003

Merged
brettcannon merged 1 commit into
python:masterfrom
tirkarthi:bpo37409
Sep 12, 2019
Merged

bpo-37409: Fix ImportWarning regarding __spec__ and __package__ being None#16003
brettcannon merged 1 commit into
python:masterfrom
tirkarthi:bpo37409

Conversation

@tirkarthi

@tirkarthi tirkarthi commented Sep 11, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Sep 11, 2019
eamanu
eamanu approved these changes Sep 12, 2019
View reviewed changes

@eamanu eamanu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brettcannon
brettcannon merged commit 6e1a30b into python:master Sep 12, 2019
@tirkarthi

tirkarthi commented Sep 12, 2019

Copy link
Copy Markdown
Member Author

DinoV pushed a commit to DinoV/cpython that referenced this pull request Sep 12, 2019
@tirkarthi @DinoV
Fix the ImportWarning regarding __spec__ and __package__ being None (p…
8f58cc2 
…ythonGH-16003)
@miss-islington

miss-islington commented Sep 13, 2019

Copy link
Copy Markdown
Contributor

Thanks @tirkarthi for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Sep 13, 2019

Copy link
Copy Markdown
Contributor

Thanks @tirkarthi for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Sep 13, 2019

Copy link
Copy Markdown

GH-16084 is a backport of this pull request to the 3.7 branch.

@bedevere-bot

bedevere-bot commented Sep 13, 2019

Copy link
Copy Markdown

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 13, 2019
@tirkarthi @miss-islington
Fix the ImportWarning regarding __spec__ and __package__ being None (p…
ac3840e 
…ythonGH-16003)

(cherry picked from commit 6e1a30b)

Co-authored-by: Xtreak <tir.karthi@gmail.com>
miss-islington added a commit that referenced this pull request Sep 13, 2019
@miss-islington @tirkarthi
Fix the ImportWarning regarding __spec__ and __package__ being None (G…
52c99ae 
…H-16003)

(cherry picked from commit 6e1a30b)

Co-authored-by: Xtreak <tir.karthi@gmail.com>
miss-islington added a commit that referenced this pull request Sep 13, 2019
@miss-islington @tirkarthi
Fix the ImportWarning regarding __spec__ and __package__ being None (G…
d3f8a11 
…H-16003)

(cherry picked from commit 6e1a30b)

Co-authored-by: Xtreak <tir.karthi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes
+1 more reviewer
@eamanu eamanu eamanu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tirkarthi @miss-islington @bedevere-bot @brettcannon @eamanu @matrixise @the-knights-who-say-ni