{{ message }}
gh-131178: Add tests for ensurepip command-line interface - #157154
Open
iamsharduld wants to merge 2 commits into
Open
gh-131178: Add tests for ensurepip command-line interface#157154iamsharduld wants to merge 2 commits into
ensurepip command-line interface#157154iamsharduld wants to merge 2 commits into
Conversation
The documented options of ``python -m ensurepip`` (--upgrade, --user, --root, --altinstall, --default-pip, --verbose) were only tested through bootstrap(), not through the command line. Drive each one through _main() with pip mocked, including the altinstall/default-pip conflict, --help and an unknown option.
9 tasks
Contributor
Author
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documented command-line interface of
ensurepiphas six options, buttest_ensurepip.pyonly called_main()with--versionand with no arguments. The options themselves were covered only throughbootstrap(), so a mistake in the argument parser or in how_main()forwards the parsed options would not have been caught.This adds tests to the existing
TestBootstrappingMainFunctionclass, one per documented option, in the same style as theTestBootstraptests (pip is mocked, the arguments passed to pip andENSUREPIP_OPTIONSare asserted):--root,--user,--upgradeand-U,-v/--verbose/-vv/ repeated-v--altinstall,--default-pip, and the documented exception when both are given--helplists every documented option and does not run pipTests-only; a NEWS entry is included in the Tests section like the earlier PRs in this series that shipped one.
Ran
test_ensurepip(also with-R 3:3),make patchcheckand the pre-commit hooks on macOS.