{{ message }}
gh-157025: Fix transport cleanup when cancelling asyncio native sendfile - #157027
Open
lpyu001 wants to merge 2 commits into
Open
gh-157025: Fix transport cleanup when cancelling asyncio native sendfile#157027lpyu001 wants to merge 2 commits into
lpyu001 wants to merge 2 commits into
Conversation
… sendfile Ensure cancellation while native sendfile waits for the write buffer to drain resets the empty waiter, restores the prior reading state, and restores the selector transport registry entry.
lpyu001
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
September 6, 2026 08:56
Contributor
There was a problem hiding this comment.
you can just move _make_empty_waiter call inside the try block
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure cancellation while native sendfile waits for the write buffer to drain resets the empty waiter, restores the prior reading state, and restores the selector transport registry entry.