{{ message }}
gh-102475: Fix os.path.realpath() for names which look like a drive - #155399
Merged
serhiy-storchaka merged 1 commit intoAug 29, 2026
Merged
Conversation
…rive The unresolved part of the path was joined with the resolved part using join(), so a component containing a colon (e.g. "spam:eggs") reset the path. It is now simply appended. A path relative to a drive which does not exist (e.g. "Z:spam") is now resolved against the root directory of that drive, as the Windows path normalization does.
serhiy-storchaka
added
needs backport to 3.13
|
GH-156593 is a backport of this pull request to the 3.15 branch. |
bedevere-app
Bot
removed
the
needs backport to 3.15
|
GH-156594 is a backport of this pull request to the 3.14 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Aug 29, 2026
…drive (GH-155399) (GH-156595) The unresolved part of the path was joined with the resolved part using join(), so a component containing a colon (e.g. "spam:eggs") reset the path. It is now simply appended. A path relative to a drive which does not exist (e.g. "Z:spam") is now resolved against the root directory of that drive, as the Windows path normalization does. (cherry picked from commit 0c38e05) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka
added a commit
that referenced
this pull request
Aug 29, 2026
…drive (GH-155399) (GH-156594) The unresolved part of the path was joined with the resolved part using join(), so a component containing a colon (e.g. "spam:eggs") reset the path. It is now simply appended. A path relative to a drive which does not exist (e.g. "Z:spam") is now resolved against the root directory of that drive, as the Windows path normalization does. (cherry picked from commit 0c38e05) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
clin1234
pushed a commit
to clin1234/cpython
that referenced
this pull request
Sep 12, 2026
…rive (pythonGH-155399) The unresolved part of the path was joined with the resolved part using join(), so a component containing a colon (e.g. "spam:eggs") reset the path. It is now simply appended. A path relative to a drive which does not exist (e.g. "Z:spam") is now resolved against the root directory of that drive, as the Windows path normalization does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation says that in the non-strict mode the unresolved part of the path is appended, but it was joined with
join(), which resets the path if the tail looks like a drive:>>> ntpath.realpath('C:/spam/a:b') 'a:b'It is now simply appended, using the naive join suggested by @eryksun.
realpath()also usedjoin(cwd, path)for a relative path, which left a path relative to another drive unresolved. It now usesabspath(), so such path is resolved against the root directory of that drive, asGetFullPathNameW()does: