{{ message }}
gh-152433: Windows: allow build ceval.c for UWP - #152689
Open
thexai wants to merge 1 commit into
Open
Conversation
chris-eibl
reviewed
Jun 30, 2026
Member
There was a problem hiding this comment.
Hm, since SetThreadStackGuarantee isn't available for UWP, we can't use it here, but since
Sets the minimum size of the stack associated with the calling thread or fiber that will be available during any stack overflow exceptions. This is useful for handling stack overflow exceptions; the application can safely use the specified number of bytes during exception handling.
we'd lose that in case of UWP :(
I think this ok, cc @markshannon?
thexai
changed the title
ceval.c allow build in UWPceval.c for UWP
chris-eibl
approved these changes
Sep 5, 2026
chris-eibl
left a comment
chris-eibl
left a comment
Member
There was a problem hiding this comment.
This is sitting for a while now. If nobody objects, I'm gonna merge end of next week at the latest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows: allow build
ceval.cfor UWP.