gh-152433: Windows: allow build socketmodule for UWP by thexai · Pull Request #152601 · python/cpython · GitHub
Skip to content

gh-152433: Windows: allow build socketmodule for UWP - #152601

Open
thexai wants to merge 1 commit into
python:mainfrom
thexai:uwp-socketmodule
Open

gh-152433: Windows: allow build socketmodule for UWP#152601
thexai wants to merge 1 commit into
python:mainfrom
thexai:uwp-socketmodule

Conversation

@thexai

@thexai thexai commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Windows: allow build socketmodule for UWP.

@thexai

thexai commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

@chris-eibl chris-eibl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@thexai

thexai commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

Rebased to resolve merge conflict.

@chris-eibl

Copy link
Copy Markdown
Member

@thexai: please don't force push, this makes incremental reviews so much harder. See also our devguide.

This PR still lgtm and is sitting for a while now. If nobody objects, I'm gonna merge end of next week at the latest.

@thexai

thexai commented Sep 5, 2026

Copy link
Copy Markdown
Contributor Author

Rebased and force pushed due merge conflict.

@chris-eibl

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants