bpo-37641 preserve relative file location in embeddable zip by mrginglymus · Pull Request #14884 · python/cpython · GitHub
Skip to content

bpo-37641 preserve relative file location in embeddable zip - #14884

Merged
zooba merged 2 commits into
python:masterfrom
mrginglymus:bpo-37641-embeddable-zip-files
Jul 25, 2019
Merged

bpo-37641 preserve relative file location in embeddable zip#14884
zooba merged 2 commits into
python:masterfrom
mrginglymus:bpo-37641-embeddable-zip-files

Conversation

@mrginglymus

@mrginglymus mrginglymus commented Jul 21, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Previously, pyc files in the embeddable distribution reported their
location as /.py. This causes a little confusion
when interpreting stack traces as the file is in a (almost certainly)
incorrect location, and lacks the full relative path to Lib (e.g.
email/mime/image.py will only show image.py).

This change preserves the Lib relative location of the source file as a
path so that stack traces are (hopefully) less misleading and more
informative.

https://bugs.python.org/issue37641

@mrginglymus
bpo-37641 preserve relative file location in embeddable zip
07e31e1 
Previously, pyc files in the embeddable distribution reported their
location as <build path>/<file stem>.py. This causes a little confusion
when interpreting stack traces as the file is in a (almost certainly)
incorrect location, and lacks the full relative path to Lib (e.g.
email/mime/image.py will only show image.py).

This change preserves the Lib relative location of the source file as a
path so that stack traces are (hopefully) less misleading and more
informative.
@mrginglymus
mrginglymus requested a review from a team as a code owner July 21, 2019 17:45
@the-knights-who-say-ni

the-knights-who-say-ni commented Jul 21, 2019

Copy link
Copy Markdown

@aeros

aeros commented Jul 21, 2019

Copy link
Copy Markdown
Contributor

@mrginglymus the build error which occured: [distutils/examples:267] "" found in "This is the description of the foobar package."` involves a documentation build issue that was addressed recently.

If the tests are ran again, this issue should no longer occur, based on Ned's response in the python-dev mailing list. In order to restart the tests, you can make a commit to your PR branch that adds trivial whitespace, such an empty comment.

@mrginglymus

mrginglymus commented Jul 22, 2019

Copy link
Copy Markdown
Contributor Author

Thanks @aeros167, I’ll wait for the CLA to come through before pushing.

@zooba

zooba commented Jul 23, 2019

Copy link
Copy Markdown
Member

Looks great, thanks for this!

Anyone who sees this can merge once the CLA is cleared, or else ping the bug again and I'll finish it up.

@aeros

aeros commented Jul 23, 2019

Copy link
Copy Markdown
Contributor

@mrginglymus If you signed the CLA over 24 hours ago and it's still not updating on GitHub, try using the check yourself link from @the-knights-who-say-ni. Sometimes you have to manually check the status for it to properly update, I remember having to do that for mine.

aeros
aeros reviewed Jul 23, 2019
View reviewed changes
Comment thread PC/layout/main.py Outdated
@mrginglymus @aeros
bpo-37641 add comment referencing bpo issue
a88abcd 
Co-Authored-By: Kyle Stanley <aeros167@gmail.com>
@zooba
zooba merged commit c4cda43 into python:master Jul 25, 2019
@miss-islington

miss-islington commented Jul 25, 2019

Copy link
Copy Markdown
Contributor

Thanks @mrginglymus for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 25, 2019
@mrginglymus @miss-islington
bpo-37641 preserve relative file location in embeddable zip (pythonGH…
2465873 
…-14884)

Previously, pyc files in the embeddable distribution reported their
location as <build path>/<file stem>.py. This causes a little confusion
when interpreting stack traces as the file is in a (almost certainly)
incorrect location, and lacks the full relative path to Lib (e.g.
email/mime/image.py will only show image.py).

This change preserves the Lib relative location of the source file as a
path so that stack traces are (hopefully) less misleading and more
informative.

Co-Authored-By: Kyle Stanley <aeros167@gmail.com>
(cherry picked from commit c4cda43)

Co-authored-by: Bill Collins <bilbocollins@gmail.com>
@bedevere-bot

bedevere-bot commented Jul 25, 2019

Copy link
Copy Markdown

miss-islington added a commit that referenced this pull request Jul 25, 2019
@miss-islington @mrginglymus
bpo-37641 preserve relative file location in embeddable zip (GH-14884)
0f21197 
Previously, pyc files in the embeddable distribution reported their
location as <build path>/<file stem>.py. This causes a little confusion
when interpreting stack traces as the file is in a (almost certainly)
incorrect location, and lacks the full relative path to Lib (e.g.
email/mime/image.py will only show image.py).

This change preserves the Lib relative location of the source file as a
path so that stack traces are (hopefully) less misleading and more
informative.

Co-Authored-By: Kyle Stanley <aeros167@gmail.com>
(cherry picked from commit c4cda43)

Co-authored-by: Bill Collins <bilbocollins@gmail.com>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@mrginglymus @aeros @lisroach
bpo-37641 preserve relative file location in embeddable zip (pythonGH…
f773bbf 
…-14884)

Previously, pyc files in the embeddable distribution reported their
location as <build path>/<file stem>.py. This causes a little confusion
when interpreting stack traces as the file is in a (almost certainly)
incorrect location, and lacks the full relative path to Lib (e.g.
email/mime/image.py will only show image.py).

This change preserves the Lib relative location of the source file as a
path so that stack traces are (hopefully) less misleading and more
informative.

Co-Authored-By: Kyle Stanley <aeros167@gmail.com>
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@mrginglymus @aeros @DinoV
bpo-37641 preserve relative file location in embeddable zip (pythonGH…
92120b9 
…-14884)

Previously, pyc files in the embeddable distribution reported their
location as <build path>/<file stem>.py. This causes a little confusion
when interpreting stack traces as the file is in a (almost certainly)
incorrect location, and lacks the full relative path to Lib (e.g.
email/mime/image.py will only show image.py).

This change preserves the Lib relative location of the source file as a
path so that stack traces are (hopefully) less misleading and more
informative.

Co-Authored-By: Kyle Stanley <aeros167@gmail.com>
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@mrginglymus @aeros @websurfer5
bpo-37641 preserve relative file location in embeddable zip (pythonGH…
a7d8c2b 
…-14884)

Previously, pyc files in the embeddable distribution reported their
location as <build path>/<file stem>.py. This causes a little confusion
when interpreting stack traces as the file is in a (almost certainly)
incorrect location, and lacks the full relative path to Lib (e.g.
email/mime/image.py will only show image.py).

This change preserves the Lib relative location of the source file as a
path so that stack traces are (hopefully) less misleading and more
informative.

Co-Authored-By: Kyle Stanley <aeros167@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba approved these changes
+1 more reviewer
@aeros aeros aeros approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

OS-windows skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mrginglymus @the-knights-who-say-ni @aeros @zooba @miss-islington @bedevere-bot