gh-146059: Cleanup pickle fast_save_enter() test by vstinner · Pull Request #146481 · python/cpython · GitHub
Skip to content

gh-146059: Cleanup pickle fast_save_enter() test - #146481

Merged
vstinner merged 2 commits into
python:mainfrom
vstinner:pickle_fast2
Mar 27, 2026
Merged

gh-146059: Cleanup pickle fast_save_enter() test#146481
vstinner merged 2 commits into
python:mainfrom
vstinner:pickle_fast2

Conversation

@vstinner

@vstinner vstinner commented Mar 26, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Remove {"key": data}, it's not required to reproduce the bug. Simplify also deep_nested_struct(): remove the seed parameter. Fix a typo in a comment.

@vstinner
pythongh-146059: Cleanup pickle fast_save_enter() test
d11419b 
Remove {"key": data}, it's not required to reproduce the bug.
Simplify also deep_nested_struct(): remove the seed parameter.
Fix a typo in a comment.
@vstinner vstinner added skip news needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Mar 26, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Mar 26, 2026
Closed
@vstinner vstinner mentioned this pull request Mar 26, 2026
Merged
serhiy-storchaka
serhiy-storchaka reviewed Mar 26, 2026
View reviewed changes
Comment thread Lib/test/pickletester.py
@vstinner
vstinner merged commit 0c7a75a into python:main Mar 27, 2026
50 checks passed
@vstinner
vstinner deleted the pickle_fast2 branch March 27, 2026 08:13
@miss-islington-app

miss-islington-app Bot commented Mar 27, 2026

Copy link
Copy Markdown

@vstinner

vstinner commented Mar 27, 2026

Copy link
Copy Markdown
Member Author

Merged, thanks for reviewing Serhiy.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 27, 2026
@vstinner @miss-islington
pythongh-146059: Cleanup pickle fast_save_enter() test (pythonGH-146481)
bc67778 
Remove {"key": data}, it's not required to reproduce the bug.
Simplify also deep_nested_struct(): remove the seed parameter.
Fix a typo in a comment.
(cherry picked from commit 0c7a75a)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app

bedevere-app Bot commented Mar 27, 2026

Copy link
Copy Markdown

GH-146509 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Mar 27, 2026
@miss-islington-app

miss-islington-app Bot commented Mar 27, 2026

Copy link
Copy Markdown

Sorry @vstinner, I had trouble completing the backport.
Please retry by removing and re-adding the "needs backport to 3.14" label.
Please backport backport using cherry_picker on the command line.

cherry_picker 0c7a75aeef4dae87f02536ed4c42a57c13ef20e2 3.14

@miss-islington-app

miss-islington-app Bot commented Mar 27, 2026

Copy link
Copy Markdown

Sorry, @vstinner, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 0c7a75aeef4dae87f02536ed4c42a57c13ef20e2 3.13

@vstinner

vstinner commented Mar 27, 2026

Copy link
Copy Markdown
Member Author

Ah, the first backport is stuck because a test was failing on WASI: #146474. I fixed the test on WASI. I will backport this change to 3.13 once the first one is merged.

vstinner added a commit that referenced this pull request Mar 27, 2026
@miss-islington @vstinner
[3.14] gh-146059: Cleanup pickle fast_save_enter() test (GH-146481) (#…
cba5497 
…146509)

gh-146059: Cleanup pickle fast_save_enter() test (GH-146481)

Remove {"key": data}, it's not required to reproduce the bug.
Simplify also deep_nested_struct(): remove the seed parameter.
Fix a typo in a comment.
(cherry picked from commit 0c7a75a)

Co-authored-by: Victor Stinner <vstinner@python.org>
@serhiy-storchaka

serhiy-storchaka commented Mar 27, 2026

Copy link
Copy Markdown
Member

It would be nice to have tests for recursive structures, to demonstrate that that mechanism works as expected. I suspect that fast_save_enter()/fast_save_leave() are used less than needed, and they can be used more than needed (are they needed for immutable collections?)

@vstinner vstinner added needs backport to 3.13 bugs and security fixes and removed needs backport to 3.13 bugs and security fixes labels Mar 27, 2026
@miss-islington-app

miss-islington-app Bot commented Mar 27, 2026

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 27, 2026
@vstinner @miss-islington
pythongh-146059: Cleanup pickle fast_save_enter() test (pythonGH-146481)
08842d1 
Remove {"key": data}, it's not required to reproduce the bug.
Simplify also deep_nested_struct(): remove the seed parameter.
Fix a typo in a comment.
(cherry picked from commit 0c7a75a)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app

bedevere-app Bot commented Mar 27, 2026

Copy link
Copy Markdown

GH-146510 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Mar 27, 2026
vstinner added a commit that referenced this pull request Mar 27, 2026
@miss-islington @vstinner
[3.13] gh-146059: Cleanup pickle fast_save_enter() test (GH-146481) (#…
9ee6b67 
…146510)

gh-146059: Cleanup pickle fast_save_enter() test (GH-146481)

Remove {"key": data}, it's not required to reproduce the bug.
Simplify also deep_nested_struct(): remove the seed parameter.
Fix a typo in a comment.
(cherry picked from commit 0c7a75a)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot

bedevere-bot commented Mar 27, 2026

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.13 (tier-1) has failed when building commit 9ee6b67.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1441/builds/1864) and take a look at the build logs.
  4. Check if the failure is related to this commit (9ee6b67) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1441/builds/1864

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/root/buildarea/3.13.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 856, in gc_collect
    gc.collect()
ResourceWarning: unclosed file <_io.FileIO name=11 mode='wb' closefd=True>

@bedevere-bot

bedevere-bot commented Mar 27, 2026

Copy link
Copy Markdown

@pablogsal pablogsal mentioned this pull request Apr 4, 2026
Merged
clin1234 pushed a commit to clin1234/cpython that referenced this pull request Apr 16, 2026
@vstinner @clin1234
pythongh-146059: Cleanup pickle fast_save_enter() test (python#146481)
fd1d481 
Remove {"key": data}, it's not required to reproduce the bug.
Simplify also deep_nested_struct(): remove the seed parameter.
Fix a typo in a comment.
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@vstinner @ljfp
pythongh-146059: Cleanup pickle fast_save_enter() test (python#146481)
b3df6d4 
Remove {"key": data}, it's not required to reproduce the bug.
Simplify also deep_nested_struct(): remove the seed parameter.
Fix a typo in a comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

@vstinner vstinner

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @serhiy-storchaka @bedevere-bot