{{ message }}
gh-146440: Add "array_hook" parameter to JSON decoders#146441
Merged
Conversation
Add array_hook parameter, to both
Python and C implementations
jsbueno
changed the title
mpkocher
reviewed
Mar 26, 2026
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
This change is simple enough, and I have no strong objections, although I do not see an immerse need of this feature.
Please add a What's New entry.
vstinner
reviewed
Mar 26, 2026
vstinner
reviewed
Mar 26, 2026
Co-authored-by: Victor Stinner <vstinner@python.org>
This reverts commit 2a9cdd5.
Contributor
Author
|
While we are at it, what about that flaky MacOS tkinter test? Can I just ignore it? Is there a place to re-run only it when it fails? |
vstinner
reviewed
Mar 27, 2026
Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner
approved these changes
Mar 27, 2026
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM. It sounds like a reasonable addition for some specific use cases.
Co-authored-by: Victor Stinner <vstinner@python.org>
Member
Core developers can re-run failing jobs to ignore flaky issues. The tkinter failure is a flaky test, it's unrelated to your change. |
Member
clin1234
pushed a commit
to clin1234/cpython
that referenced
this pull request
Apr 16, 2026
…6441) Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Victor Stinner <vstinner@python.org>
ljfp
pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
…6441) Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Victor Stinner <vstinner@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--146441.org.readthedocs.build/