{{ message }}
gh-146431: Add the wrapcol and ignorechars parameters for more Base XX codec#146434
Merged
serhiy-storchaka merged 2 commits intoApr 1, 2026
Merged
Conversation
…Base XX codec Add the wrapcol parameter to base64 functions b16encode(), b32encode(), b32hexencode(), b85encode() and z85encode(), and binascii functions b2a_base32() and b2a_base85(). Add the ignorechars parameter to base64 functions b16decode(), b32decode(), b32hexdecode(), b85decode() and z85decode(), and binascii functions a2b_hex(), unhexlify(), a2b_base32() and a2b_base85().
serhiy-storchaka
force-pushed
the
basexx-wrapcol-ignorechars
branch
from
ea2c65d to
c88fb7a
Compare
gpshead
reviewed
Mar 31, 2026
gpshead
left a comment
gpshead
left a comment
Member
There was a problem hiding this comment.
food for thought: could wrapcol be limited to "even" columns of one decodable chunk? (at least for base16/32/64) - It makes little sense to wrap on unusual boundaries.
Member
There was a problem hiding this comment.
Suggested change
| unsigned char this_ch; | |
| unsigned char this_ch = 0; |
Member
Author
There was a problem hiding this comment.
It is always initialized before use.
Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
| if check_impl_detail(): | ||
| eq(base64.b64encode(b, wrapcol=sys.maxsize*2), | ||
| b'd3d3LnB5dGhvbi5vcmc=') | ||
| if func is not base64.b16encode: |
Member
Author
There was a problem hiding this comment.
#147944 will allow to remove some of these special cases.
Member
Author
gpshead
approved these changes
Mar 31, 2026
clin1234
pushed a commit
to clin1234/cpython
that referenced
this pull request
Apr 16, 2026
…Base XX codec (pythonGH-146434) Add the wrapcol parameter to base64 functions b16encode(), b32encode(), b32hexencode(), b85encode() and z85encode(), and binascii functions b2a_base32() and b2a_base85(). Add the ignorechars parameter to base64 functions b16decode(), b32decode(), b32hexdecode(), b85decode() and z85decode(), and binascii functions a2b_hex(), unhexlify(), a2b_base32() and a2b_base85().
ljfp
pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
…Base XX codec (pythonGH-146434) Add the wrapcol parameter to base64 functions b16encode(), b32encode(), b32hexencode(), b85encode() and z85encode(), and binascii functions b2a_base32() and b2a_base85(). Add the ignorechars parameter to base64 functions b16decode(), b32decode(), b32hexdecode(), b85decode() and z85decode(), and binascii functions a2b_hex(), unhexlify(), a2b_base32() and a2b_base85().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the wrapcol parameter to base64 functions b16encode(), b32encode(), b32hexencode(), b85encode() and z85encode(), and binascii functions b2a_base32() and b2a_base85().
Add the ignorechars parameter to base64 functions b16decode(), b32decode(), b32hexdecode(), b85decode() and z85decode(), and binascii functions a2b_hex(), unhexlify(), a2b_base32() and a2b_base85().
📚 Documentation preview 📚: https://cpython-previews--146434.org.readthedocs.build/