GH-146210: Fix building the jit stencils on Windows when the interpreter is built with a different clang version by chris-eibl · Pull Request #146338 · python/cpython · GitHub
Skip to content

GH-146210: Fix building the jit stencils on Windows when the interpreter is built with a different clang version - #146338

Merged
savannahostrowski merged 5 commits into
python:mainfrom
chris-eibl:gh146210
Apr 3, 2026
Merged

savannahostrowski merged 5 commits into
python:mainfrom
chris-eibl:gh146210

Conversation

@chris-eibl

@chris-eibl chris-eibl commented Mar 23, 2026

Copy link
Copy Markdown
Member

By dropping the environment variable INCLUDE when building the jit stencils. Since this is Windows specific, this is only done on Windows.

interpreter is built with a different clang version.

@savannahostrowski savannahostrowski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look at this!

Comment thread Tools/jit/_llvm.py Outdated
Comment thread Tools/jit/_llvm.py
@bedevere-app

bedevere-app Bot commented Apr 3, 2026

Copy link
Copy Markdown

@savannahostrowski savannahostrowski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@savannahostrowski
savannahostrowski merged commit dea4083 into python:main Apr 3, 2026
78 checks passed
@chris-eibl
chris-eibl deleted the gh146210 branch April 3, 2026 19:43
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
…terpreter is built with a different clang version (python#146338)

Co-authored-by: Savannah Ostrowski <savannah@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants