gh-145886: remove unused Event.raw field from _pyrepl by HCYT · Pull Request #146097 · python/cpython · GitHub
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions Lib/_pyrepl/base_eventqueue.py
1 change: 0 additions & 1 deletion Lib/_pyrepl/console.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@
class Event:
evt: str
data: str
raw: bytes = b""


@dataclass
Expand Down
14 changes: 4 additions & 10 deletions Lib/_pyrepl/unix_console.py
Original file line number Diff line number Diff line change
Expand Up @@ -537,19 +537,16 @@ def getpending(self):
Returns:
- Event: Pending event from the event queue.
"""
e = Event("key", "", b"")
e = Event("key", "")

while not self.event_queue.empty():
e2 = self.event_queue.get()
e.data += e2.data
e.raw += e.raw

amount = struct.unpack("i", ioctl(self.input_fd, FIONREAD, b"\0\0\0\0"))[0]
trace("getpending({a})", a=amount)
raw = self.__read(amount)
data = str(raw, self.encoding, "replace")
e.data += data
e.raw += raw
e.data += str(raw, self.encoding, "replace")
return e

else:
Expand All @@ -561,18 +558,15 @@ def getpending(self):
Returns:
- Event: Pending event from the event queue.
"""
e = Event("key", "", b"")
e = Event("key", "")

while not self.event_queue.empty():
e2 = self.event_queue.get()
e.data += e2.data
e.raw += e.raw

amount = 10000
raw = self.__read(amount)
data = str(raw, self.encoding, "replace")
e.data += data
e.raw += raw
e.data += str(raw, self.encoding, "replace")
return e

def clear(self):
Expand Down
2 changes: 1 addition & 1 deletion Lib/_pyrepl/windows_console.py
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,7 @@ def forgetinput(self) -> None:
def getpending(self) -> Event:
"""Return the characters that have been typed but not yet
processed."""
e = Event("key", "", b"")
e = Event("key", "")

while not self.event_queue.empty():
e2 = self.event_queue.get()
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_pyrepl/support.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def more_lines(text: str, namespace: dict | None = None):

def code_to_events(code: str):
for c in code:
yield Event(evt="key", data=c, raw=bytearray(c.encode("utf-8")))
yield Event(evt="key", data=c)


def clean_screen(reader: ReadlineAlikeReader) -> list[str]:
Expand Down
14 changes: 6 additions & 8 deletions Lib/test/test_pyrepl/test_eventqueue.py
Loading
Loading