gh-141510: Support `frozendict` in `plistlib` by hugovk · Pull Request #145590 · python/cpython · GitHub
Skip to content

gh-141510: Support frozendict in plistlib - #145590

Merged
hugovk merged 5 commits into
python:mainfrom
hugovk:3.15-frozendict-plistlib
Mar 31, 2026
Merged

hugovk merged 5 commits into
python:mainfrom
hugovk:3.15-frozendict-plistlib

Conversation

@hugovk

@hugovk hugovk commented Mar 6, 2026

Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka @ronaldoussoren: Do you want to double check this plistlib change?

Comment thread Doc/library/plistlib.rst Outdated
Comment thread Lib/plistlib.py Outdated
Comment thread Doc/library/plistlib.rst Outdated

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a NEWS entry. Note that support of frozendict is half-hearted -- only for serialization. dict_type=frozendict does not work in load(). I am not sure that it is worth to add support for deserialization.

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vstinner

Copy link
Copy Markdown
Member

@serhiy-storchaka

Copy link
Copy Markdown
Member

@hugovk
hugovk requested a review from AA-Turner as a code owner March 21, 2026 14:04
hugovk and others added 2 commits March 21, 2026 16:05
Co-authored-by: Victor Stinner <vstinner@python.org>

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hugovk
hugovk merged commit 829e4d0 into python:main Mar 31, 2026
50 checks passed
@hugovk
hugovk deleted the 3.15-frozendict-plistlib branch March 31, 2026 12:45
clin1234 pushed a commit to clin1234/cpython that referenced this pull request Apr 16, 2026
Co-authored-by: Victor Stinner <vstinner@python.org>
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants