iframe-proxy

eendebakpt · 2026-03-05T13:36:26Z

Issue: Various reference leaks in the core #145376

vstinner

LGTM. The RingBuf_Put() comment says "Steals a reference to item".

miss-islington-app · 2026-03-07T09:05:21Z

miss-islington-app · 2026-03-07T09:05:21Z

Thanks @eendebakpt for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

…ythonGH-145543) (cherry picked from commit 0aeaaaf) Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>

bedevere-app · 2026-03-07T09:05:39Z

GH-145621 is a backport of this pull request to the 3.13 branch.

bedevere-app · 2026-03-07T09:05:43Z

GH-145622 is a backport of this pull request to the 3.14 branch.

bedevere-bot · 2026-03-07T10:28:59Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Ubuntu Shared 3.x (tier-1) has failed when building commit 0aeaaaf.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/506/builds/12490) and take a look at the build logs.
Check if the failure is related to this commit (0aeaaaf) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/506/builds/12490

Failed tests:

test_pyrepl

Failed subtests:

test_repl_eio - test.test_pyrepl.test_unix_console.TestUnixConsoleEIOHandling.test_repl_eio

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_pyrepl/test_unix_console.py", line 390, in test_repl_eio
    _, err = proc.communicate(timeout=support.LONG_TIMEOUT)
             ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/subprocess.py", line 1273, in communicate
    stdout, stderr = self._communicate(input, endtime, timeout)
                     ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/subprocess.py", line 2293, in _communicate
    self._check_timeout(endtime, orig_timeout, stdout, stderr)
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/subprocess.py", line 1320, in _check_timeout
    raise TimeoutExpired(
    ...<2 lines>...
            stderr=b''.join(stderr_seq) if stderr_seq else None)
subprocess.TimeoutExpired: Command '['/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/python', '-E', '-S', '/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_pyrepl/eio_test_script.py']' timed out after 300.0 seconds


Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/subprocess.py", line 1191, in __del__
    _warn("subprocess %s is still running" % self.pid,
    ~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
          ResourceWarning, source=self)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ResourceWarning: subprocess 252083 is still running
Warning -- Unraisable exception
Exception ignored while finalizing file <_io.FileIO name=10 mode='rb' closefd=True>:
Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/unittest/case.py", line 666, in run
    with outcome.testPartExecutor(self):
         ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
ResourceWarning: unclosed file <_io.TextIOWrapper name=10 encoding='utf-8'>
Warning -- Unraisable exception
Exception ignored while finalizing file <_io.FileIO name=8 mode='rb' closefd=True>:
Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/unittest/case.py", line 666, in run
    with outcome.testPartExecutor(self):
         ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
ResourceWarning: unclosed file <_io.TextIOWrapper name=8 encoding='utf-8'>


Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/subprocess.py", line 1191, in __del__
    _warn("subprocess %s is still running" % self.pid,
    ~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
          ResourceWarning, source=self)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ResourceWarning: subprocess 289757 is still running
Warning -- Unraisable exception
Exception ignored while finalizing file <_io.FileIO name=10 mode='rb' closefd=True>:
Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/unittest/case.py", line 666, in run
    with outcome.testPartExecutor(self):
         ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
ResourceWarning: unclosed file <_io.TextIOWrapper name=10 encoding='utf-8'>
Warning -- Unraisable exception
Exception ignored while finalizing file <_io.FileIO name=8 mode='rb' closefd=True>:
Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/unittest/case.py", line 666, in run
    with outcome.testPartExecutor(self):
         ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
ResourceWarning: unclosed file <_io.TextIOWrapper name=8 encoding='utf-8'>

…H-145543) (#145621) gh-145376: Fix refleak in `queuemodule.c` out-of-memory path (GH-145543) (cherry picked from commit 0aeaaaf) Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>

…H-145543) (#145622) gh-145376: Fix refleak in `queuemodule.c` out-of-memory path (GH-145543) (cherry picked from commit 0aeaaaf) Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>

…ython#145543)

Fix refleak in _queuemodule.c

37c5e50

eendebakpt added the skip news label Mar 5, 2026

bedevere-app Bot mentioned this pull request Mar 5, 2026

Various reference leaks in the core #145376

Closed

bedevere-app Bot added the awaiting review label Mar 5, 2026

eendebakpt changed the title ~~gh-145376: Fix refleak in _queuemodule.c~~ gh-145376: Fix refleak in _queuemodule.c out-of-memory path Mar 5, 2026

vstinner approved these changes Mar 5, 2026

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting review labels Mar 5, 2026

kumaraditya303 approved these changes Mar 7, 2026

View reviewed changes

kumaraditya303 merged commit 0aeaaaf into python:main Mar 7, 2026
56 checks passed

bedevere-app Bot removed the awaiting merge label Mar 7, 2026

kumaraditya303 added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Mar 7, 2026

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Mar 7, 2026

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Mar 7, 2026

eendebakpt deleted the refleak_queuemodule branch March 19, 2026 21:39

ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026

pythongh-145376: Fix refleak in queuemodule.c out-of-memory path (p…

684e45f

…ython#145543)

Sunbelt Computer Software

PL/B Language Development and Support

Navigation Menu

Uh oh!

Uh oh!

gh-145376: Fix refleak in _queuemodule.c out-of-memory path - #145543

gh-145376: Fix refleak in _queuemodule.c out-of-memory path#145543
kumaraditya303 merged 1 commit into
python:mainfrom
eendebakpt:refleak_queuemodule

eendebakpt commented Mar 5, 2026 •

edited by bedevere-app Bot

Loading

Uh oh!

vstinner left a comment

Uh oh!

Uh oh!

miss-islington-app Bot commented Mar 7, 2026

Uh oh!

miss-islington-app Bot commented Mar 7, 2026

Uh oh!

bedevere-app Bot commented Mar 7, 2026

Uh oh!

bedevere-app Bot commented Mar 7, 2026

Uh oh!

bedevere-bot commented Mar 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Uh oh!

Conversation

eendebakpt commented Mar 5, 2026 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

miss-islington-app Bot commented Mar 7, 2026

Uh oh!

miss-islington-app Bot commented Mar 7, 2026

Uh oh!

bedevere-app Bot commented Mar 7, 2026

Uh oh!

bedevere-app Bot commented Mar 7, 2026

Uh oh!

bedevere-bot commented Mar 7, 2026

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

eendebakpt commented Mar 5, 2026 •

edited by bedevere-app Bot

Loading