gh-145035: Allows removing the _pyrepl module to completely disable the modern REPL by zooba · Pull Request #145159 · python/cpython · GitHub
Skip to content

gh-145035: Allows removing the _pyrepl module to completely disable the modern REPL - #145159

Merged
ambv merged 5 commits into
python:mainfrom
zooba:gh-145035
Mar 10, 2026
Merged

ambv merged 5 commits into
python:mainfrom
zooba:gh-145035

Conversation

@zooba

@zooba zooba commented Feb 23, 2026

Copy link
Copy Markdown
Member

This is an unsupported configuration, but still desirable for some distributions. It also ensures we can continue to keep ctypes as an optional module.

@zooba

zooba commented Feb 23, 2026

Copy link
Copy Markdown
Member Author

@zooba

zooba commented Feb 23, 2026

Copy link
Copy Markdown
Member Author

First try :shipit: Reverting my little hack for hiding the module and will un-draft.

@johnslavik
johnslavik self-requested a review February 24, 2026 00:09
Comment thread Lib/_sitebuiltins.py
@zooba

zooba commented Mar 3, 2026

Copy link
Copy Markdown
Member Author

@pablogsal Any concerns about this PR? (FWIW, I'll be maintaining the patch in my fork/backports anyway, this is just to make my[/my successor's] life easier by having the support in main as well.)

@FFY00 FFY00 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell, this implementation seems okay to me. The only thing I could maybe suggest, is that it could make sense to move all the alternative necessary bits — such as the pager implementations — to a built-in module, providing the basic functionality. Though, I really have no strong feelings towards it.

That said, I believe this is a very welcome UX improvement, especially bundled with the other small UX improvements around initialization in 3.15.

@ambv
ambv merged commit ae0d287 into python:main Mar 10, 2026
51 checks passed
@zooba

zooba commented Mar 16, 2026

Copy link
Copy Markdown
Member Author

ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@zooba
zooba deleted the gh-145035 branch June 10, 2026 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants