iframe-proxy

StanFromIreland · 2026-02-17T18:28:00Z

Like #144878 just yesterday... we should start running this test somewhere.

Issue: PEP 814: Add built-in frozendict type #141510

vstinner

LGTM. I confirm that ./python -m test test_xpickle -u xpickle fails without the change, and pass successfully with the change.

vstinner · 2026-02-17T20:26:41Z

StanFromIreland · 2026-02-17T20:27:29Z

Thanks for the review/merge.

bedevere-bot · 2026-02-17T21:36:46Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Ubuntu Shared 3.x (tier-1) has failed when building commit fa73fd4.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/506/builds/12367) and take a look at the build logs.
Check if the failure is related to this commit (fa73fd4) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/506/builds/12367

Failed tests:

test_pyrepl

Failed subtests:

test_repl_eio - test.test_pyrepl.test_unix_console.TestUnixConsoleEIOHandling.test_repl_eio

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/subprocess.py", line 1191, in __del__
    _warn("subprocess %s is still running" % self.pid,
    ~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
          ResourceWarning, source=self)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ResourceWarning: subprocess 2393482 is still running
Warning -- Unraisable exception
Exception ignored while finalizing file <_io.FileIO name=10 mode='rb' closefd=True>:
Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/unittest/case.py", line 666, in run
    with outcome.testPartExecutor(self):
         ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
ResourceWarning: unclosed file <_io.TextIOWrapper name=10 encoding='utf-8'>
Warning -- Unraisable exception
Exception ignored while finalizing file <_io.FileIO name=8 mode='rb' closefd=True>:
Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/unittest/case.py", line 666, in run
    with outcome.testPartExecutor(self):
         ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
ResourceWarning: unclosed file <_io.TextIOWrapper name=8 encoding='utf-8'>


Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_pyrepl/test_unix_console.py", line 390, in test_repl_eio
    _, err = proc.communicate(timeout=support.LONG_TIMEOUT)
             ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/subprocess.py", line 1273, in communicate
    stdout, stderr = self._communicate(input, endtime, timeout)
                     ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/subprocess.py", line 2293, in _communicate
    self._check_timeout(endtime, orig_timeout, stdout, stderr)
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/subprocess.py", line 1320, in _check_timeout
    raise TimeoutExpired(
    ...<2 lines>...
            stderr=b''.join(stderr_seq) if stderr_seq else None)
subprocess.TimeoutExpired: Command '['/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/python', '-E', '-S', '/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/test/test_pyrepl/eio_test_script.py']' timed out after 300.0 seconds


Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/subprocess.py", line 1191, in __del__
    _warn("subprocess %s is still running" % self.pid,
    ~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
          ResourceWarning, source=self)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ResourceWarning: subprocess 2400081 is still running
Warning -- Unraisable exception
Exception ignored while finalizing file <_io.FileIO name=10 mode='rb' closefd=True>:
Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/unittest/case.py", line 666, in run
    with outcome.testPartExecutor(self):
         ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
ResourceWarning: unclosed file <_io.TextIOWrapper name=10 encoding='utf-8'>
Warning -- Unraisable exception
Exception ignored while finalizing file <_io.FileIO name=8 mode='rb' closefd=True>:
Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.x.bolen-ubuntu/build/Lib/unittest/case.py", line 666, in run
    with outcome.testPartExecutor(self):
         ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
ResourceWarning: unclosed file <_io.TextIOWrapper name=8 encoding='utf-8'>

Fix test_xpickle failing with introduction of frozendict

34913b1

StanFromIreland requested review from corona10 and vstinner February 17, 2026 18:28

bedevere-app Bot added the awaiting review label Feb 17, 2026

StanFromIreland added tests Tests in the Lib/test dir skip issue skip news labels Feb 17, 2026

StanFromIreland mentioned this pull request Feb 17, 2026

test_xpickle isn't running (failing) anywhere #144930

Closed

vstinner removed the skip issue label Feb 17, 2026

vstinner changed the title ~~Fix test_xpickle failing with introduction of frozendict~~ gh-141510: Fix test_xpickle failing with introduction of frozendict Feb 17, 2026

bedevere-app Bot mentioned this pull request Feb 17, 2026

PEP 814: Add built-in frozendict type #141510

Closed

vstinner approved these changes Feb 17, 2026

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting review labels Feb 17, 2026

vstinner merged commit fa73fd4 into python:main Feb 17, 2026
59 checks passed

bedevere-app Bot removed the awaiting merge label Feb 17, 2026

StanFromIreland deleted the test_xpickle branch February 17, 2026 20:26

brijkapadia pushed a commit to brijkapadia/cpython that referenced this pull request Feb 28, 2026

pythongh-141510: Update test_xpickle for frozendict (python#144927)

b5d4f89

ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026

pythongh-141510: Update test_xpickle for frozendict (python#144927)

0842006

Sunbelt Computer Software

PL/B Language Development and Support

Navigation Menu

Uh oh!

Uh oh!

gh-141510: Fix `test_xpickle` failing with introduction of `frozendict` - #144927

gh-141510: Fix `test_xpickle` failing with introduction of `frozendict`#144927
vstinner merged 1 commit into
python:mainfrom
StanFromIreland:test_xpickle

StanFromIreland commented Feb 17, 2026 •

edited by bedevere-app Bot

Loading

Uh oh!

vstinner left a comment

Uh oh!

Uh oh!

vstinner commented Feb 17, 2026

Uh oh!

StanFromIreland commented Feb 17, 2026

Uh oh!

bedevere-bot commented Feb 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Uh oh!

Conversation

StanFromIreland commented Feb 17, 2026 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vstinner commented Feb 17, 2026

Uh oh!

StanFromIreland commented Feb 17, 2026

Uh oh!

bedevere-bot commented Feb 17, 2026

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

StanFromIreland commented Feb 17, 2026 •

edited by bedevere-app Bot

Loading