Remove `PYEXPAT_EXPORTS` usage from `PCBuild/pyexpat.vcxproj` by maxbachmann · Pull Request #144462 · python/cpython · GitHub
Skip to content

Remove PYEXPAT_EXPORTS usage from PCBuild/pyexpat.vcxproj#144462

Merged
zooba merged 1 commit into
python:mainfrom
maxbachmann:patch-9
Feb 3, 2026
Merged

Remove PYEXPAT_EXPORTS usage from PCBuild/pyexpat.vcxproj#144462
zooba merged 1 commit into
python:mainfrom
maxbachmann:patch-9

Conversation

@maxbachmann

@maxbachmann maxbachmann commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

Looking through the history I was unable to find any revision where this actually did anything.

This should be a trivial enough change that it doesn't require a separate issue/news entry

@maxbachmann maxbachmann requested a review from a team as a code owner February 3, 2026 22:52
@maxbachmann

Copy link
Copy Markdown
Contributor Author

@picnixz picnixz changed the title remove non existent config macro Remove PYEXPAT_EXPORTS usage from PCBuild/pyexpat.vcxproj Feb 3, 2026
@picnixz

picnixz commented Feb 3, 2026

Copy link
Copy Markdown
Member

cc @hartwork

@zooba zooba added OS-windows skip issue skip news build The build process and cross-build labels Feb 3, 2026
@zooba

zooba commented Feb 3, 2026

Copy link
Copy Markdown
Member

Seems trivial to me, I don't see any uses of the variable anywhere.

@zooba zooba merged commit 9d0c743 into python:main Feb 3, 2026
55 checks passed
@hartwork

hartwork commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build The build process and cross-build OS-windows skip issue skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants