iframe-proxy

heikkitoivonen · 2026-01-08T23:15:49Z

Issue: Unit tests for collections.Counter comparisons need cases for missing keys #143586

bedevere-bot · 2026-01-10T07:53:42Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD Refleaks 3.x (tier-3) has failed when building commit 78e868f.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1613/builds/2656) and take a look at the build logs.
Check if the failure is related to this commit (78e868f) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1613/builds/2656

Test leaking resources:

test_events: memory blocks
test_events: references

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/test/support/__init__.py", line 947, in gc_collect
    gc.collect()
    ~~~~~~~~~~^^
ResourceWarning: unclosed <socket.socket fd=9, family=2, type=1, proto=6, laddr=('127.0.0.1', 50615), raddr=('127.0.0.1', 50616)>
Task was destroyed but it is pending!
task: <Task pending name='Task-3846' coro=<BaseSelectorEventLoop._accept_connection2() done, defined at /buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/asyncio/selector_events.py:217> wait_for=<Future pending cb=[Task.task_wakeup()]>>
Warning -- Unraisable exception
Exception ignored while calling deallocator <function _SelectorTransport.__del__ at 0x844f49fd0>:
Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/asyncio/selector_events.py", line 873, in __del__
    _warn(f"unclosed transport {self!r}", ResourceWarning, source=self)
    ~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ResourceWarning: unclosed transport <_SelectorSocketTransport closing fd=9>
k


Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/test/support/__init__.py", line 947, in gc_collect
    gc.collect()
    ~~~~~~~~~~^^
ResourceWarning: unclosed <socket.socket fd=9, family=2, type=1, proto=6, laddr=('127.0.0.1', 49445), raddr=('127.0.0.1', 49446)>
Task was destroyed but it is pending!
task: <Task pending name='Task-4088' coro=<BaseSelectorEventLoop._accept_connection2() done, defined at /buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/asyncio/selector_events.py:217> wait_for=<Future pending cb=[Task.task_wakeup()]>>
Warning -- Unraisable exception
Exception ignored while calling deallocator <function _SelectorTransport.__del__ at 0x8422d9fd0>:
Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/asyncio/selector_events.py", line 873, in __del__
    _warn(f"unclosed transport {self!r}", ResourceWarning, source=self)
    ~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ResourceWarning: unclosed transport <_SelectorSocketTransport closing fd=9>
k


Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/test/support/__init__.py", line 947, in gc_collect
    gc.collect()
    ~~~~~~~~~~^^
ResourceWarning: unclosed <socket.socket fd=9, family=2, type=1, proto=6, laddr=('127.0.0.1', 48548), raddr=('127.0.0.1', 48549)>
Task was destroyed but it is pending!
task: <Task pending name='Task-1026' coro=<BaseSelectorEventLoop._accept_connection2() done, defined at /buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/asyncio/selector_events.py:217> wait_for=<Future pending cb=[Task.task_wakeup()]>>
Warning -- Unraisable exception
Exception ignored while calling deallocator <function _SelectorTransport.__del__ at 0x8422d9fd0>:
Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/asyncio/selector_events.py", line 873, in __del__
    _warn(f"unclosed transport {self!r}", ResourceWarning, source=self)
    ~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ResourceWarning: unclosed transport <_SelectorSocketTransport closing fd=9>
k


Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/test/support/__init__.py", line 947, in gc_collect
    gc.collect()
    ~~~~~~~~~~^^
ResourceWarning: unclosed <socket.socket fd=9, family=2, type=1, proto=6, laddr=('127.0.0.1', 49373), raddr=('127.0.0.1', 49374)>
Task was destroyed but it is pending!
task: <Task pending name='Task-3856' coro=<BaseSelectorEventLoop._accept_connection2() done, defined at /buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/asyncio/selector_events.py:217> wait_for=<Future pending cb=[Task.task_wakeup()]>>
Warning -- Unraisable exception
Exception ignored while calling deallocator <function _SelectorTransport.__del__ at 0x8422d9fd0>:
Traceback (most recent call last):
  File "/buildbot/buildarea/3.x.ware-freebsd.refleak/build/Lib/asyncio/selector_events.py", line 873, in __del__
    _warn(f"unclosed transport {self!r}", ResourceWarning, source=self)
    ~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ResourceWarning: unclosed transport <_SelectorSocketTransport closing fd=9>
k

heikkitoivonen · 2026-01-10T18:25:11Z

…ent semantics (pythongh-143587)

Add Counter comparison tests to enforce missing element semantics

dd9fb4c

heikkitoivonen requested a review from rhettinger as a code owner January 8, 2026 23:15

bedevere-app Bot added tests Tests in the Lib/test dir awaiting review labels Jan 8, 2026

bedevere-app Bot mentioned this pull request Jan 8, 2026

Unit tests for collections.Counter comparisons need cases for missing keys #143586

Closed

StanFromIreland reviewed Jan 9, 2026

View reviewed changes

Comment thread Misc/NEWS.d/next/Tests/2026-01-08-15-04-38.gh-issue-143586.jLL4wL.rst Outdated

picnixz added the skip news label Jan 9, 2026

Tests do not need news entry

d21fc0d

rhettinger merged commit 78e868f into python:main Jan 10, 2026
44 checks passed

bedevere-app Bot removed the awaiting review label Jan 10, 2026

reidenong pushed a commit to reidenong/cpython that referenced this pull request Jan 12, 2026

pythongh-143586: Add Counter comparison tests to enforce missing elem…

243432c

…ent semantics (pythongh-143587)

thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026

pythongh-143586: Add Counter comparison tests to enforce missing elem…

e6d71e5

…ent semantics (pythongh-143587)

Sunbelt Computer Software

PL/B Language Development and Support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

gh-143586: Add Counter comparison tests to enforce missing element semantics#143587

gh-143586: Add Counter comparison tests to enforce missing element semantics#143587
rhettinger merged 2 commits into
python:mainfrom
heikkitoivonen:counter-tests-for-missing-keys

heikkitoivonen commented Jan 8, 2026 •

edited by bedevere-app Bot

Loading

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Jan 10, 2026

Uh oh!

heikkitoivonen commented Jan 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Uh oh!

Conversation

heikkitoivonen commented Jan 8, 2026 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Jan 10, 2026

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

heikkitoivonen commented Jan 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

heikkitoivonen commented Jan 8, 2026 •

edited by bedevere-app Bot

Loading